feat: report ? for unknown node versions

Author: dominykas

lib/travis.js

@@ -64,10 +64,11 @@ internals.scan = async (travisYaml) => {
         const nv = await Nv(version);
 
         if (!nv.length) {
-            continue;
+            resolved.push('?');
+        }
+        else {
+            resolved.push(nv[nv.length - 1].version);
         }
-
-        resolved.push(nv[nv.length - 1].version);
     }
 
     return { raw, resolved };

test/fixtures/testing-invalid-version.yml

@@ -0,0 +1,2 @@
+language: node_js
+node_js: "i-am-not-a-node-version"

test/index.js

@@ -375,6 +375,27 @@ describe('node-support', () => {
                 });
             });
 
+            it('handles invalid node versions', async () => {
+
+                const path = await internals.prepareFixture({
+                    travisYml: 'testing-invalid-version.yml'
+                });
+
+                const result = await NodeSupport.detect({ path });
+
+                internals.assertCommit(result);
+
+                expect(result).to.equal({
+                    name: 'test-module',
+                    version: '0.0.0-development',
+                    timestamp: 1580673602000,
+                    travis: {
+                        raw: ['i-am-not-a-node-version'],
+                        resolved: ['?']
+                    }
+                });
+            });
+
             it('throws when path is not a git repo', async () => {
 
                 const path = await internals.prepareFixture({ git: false });