fix: skip validate dynamic templateref (argoproj#14850)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

Author: tczhao

workflow/validate/validate.go

@@ -574,6 +574,10 @@ func (tctx *templateValidationCtx) validateTemplateHolder(ctx context.Context, t
 	tmplCtx, resolvedTmpl, _, err := tmplCtx.ResolveTemplate(ctx, tmplHolder)
 	if err != nil {
 		if argoerr, ok := err.(errors.ArgoError); ok && argoerr.Code() == errors.CodeNotFound {
+			if tmplRef != nil && strings.Contains(tmplRef.Template, "placeholder") {
+				// placeholder indicate this is a dynamic template, skip validation
+				return nil, nil
+			}
 			if tmplRef != nil {
 				return nil, errors.Errorf(errors.CodeBadRequest, "template reference %s.%s not found", tmplRef.Name, tmplRef.Template)
 			}

workflow/validate/validate_dag_test.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/stretchr/testify/require"
 
+	wfv1 "github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
 	"github.com/argoproj/argo-workflows/v3/util/logging"
 )
 
@@ -1124,3 +1125,102 @@ func TestFailDAGArgParamValueFromPathInTask(t *testing.T) {
 	err := validate(logging.TestContext(t.Context()), failDagArgParamValueFromPathInTask)
 	require.ErrorContains(t, err, "valueFrom only allows: default, configMapKeyRef and supplied")
 }
+
+var dagWithItemTemplateRefTmpl = `
+apiVersion: argoproj.io/v1alpha1
+kind: WorkflowTemplate
+metadata:
+  name: 363-test-tmp
+  namespace: default
+spec:
+  templates:
+    - name: 363-test-tmp
+      nodeSelector:
+        nodegroup: arm-spot
+      inputs:
+        parameters:
+          - name: path
+          - name: service
+          - name: build_arg
+          - name: run_on
+          - name: arch
+          - name: docker_org
+      container:
+        image: alpine
+        command:
+          - sh
+          - -c
+          - |
+            echo "path: {{inputs.parameters.path}}"
+            echo "service: {{inputs.parameters.service}}"
+            echo "build_arg: {{inputs.parameters.build_arg}}"
+            echo "run_on: {{inputs.parameters.run_on}}"
+            echo "arch: {{inputs.parameters.arch}}"
+            echo "docker_org: {{inputs.parameters.docker_org}}"
+`
+
+var dagWithItemTemplateRefWf = `
+apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+  generateName: 363-test-
+  namespace: default
+spec:
+  activeDeadlineSeconds: 10800
+  entrypoint: main
+  serviceAccountName: ci
+
+  templates:
+    - name: main
+      dag:
+        tasks:
+          - name: withitems
+            templateRef:
+              name: 363-test-tmp
+              template: 363-test-tmp
+            arguments:
+              parameters:
+                - name: path
+                  value: "{{item.path}}"
+                - name: service
+                  value: "{{item.service}}"
+                - name: build_arg
+                  value: "{{item.arg}}"
+                - name: run_on
+                  value: "{{item.run_on}}"
+                - name: arch
+                  value: "{{item.arch}}"
+                - name: docker_org
+                  value: "{{item.docker_org}}"
+            withItems:
+              - {
+                  path: "services",
+                  service: "id",
+                  arg: "",
+                  run_on: "arm-spot",
+                  arch: "arm64",
+                  docker_org: "pipekit13",
+                }
+              - {
+                  path: "services",
+                  service: "events-handler",
+                  arg: "",
+                  run_on: "arm-spot",
+                  arch: "arm64",
+                  docker_org: "pipekit13",
+                }
+`
+
+func TestDagWithItemTemplateRefTmpl(t *testing.T) {
+	ctx := logging.TestContext(t.Context())
+	wf := wfv1.MustUnmarshalWorkflow(dagWithItemTemplateRefWf)
+	wftmpl := wfv1.MustUnmarshalWorkflowTemplate(dagWithItemTemplateRefTmpl)
+
+	err := createWorkflowTemplate(ctx, wftmpl)
+	require.NoError(t, err)
+
+	err = ValidateWorkflow(ctx, wftmplGetter, cwftmplGetter, wf, nil, ValidateOpts{})
+	require.NoError(t, err)
+
+	_ = deleteWorkflowTemplate(ctx, wftmpl.Name)
+}

workflow/validate/validate_test.go

@@ -3365,3 +3365,73 @@ func TestShouldCheckValidationToSpacedParameters(t *testing.T) {
 	// Do not allow leading or trailing spaces in parameters
 	require.ErrorContains(t, err, "failed to resolve {{  workflow.thisdoesnotexist  }}")
 }
+
+var dynamicWorkflowTemplateARefB = `
+apiVersion: argoproj.io/v1alpha1
+kind: WorkflowTemplate
+metadata:
+  name: workflow-template-a
+spec:
+  templates:
+  - name: template-a
+    inputs:
+      parameters:
+        - name: message
+    steps:
+      - - name: step-a
+          templateRef:
+            name: workflow-template-b
+            template: "{{ inputs.parameters.message }}"
+`
+
+var dynamicWorkflowTemplateRefB = `
+apiVersion: argoproj.io/v1alpha1
+kind: WorkflowTemplate
+metadata:
+  name: workflow-template-b
+spec:
+  templates:
+  - name: template-b
+    container:
+      image: docker/whalesay
+      command: [cowsay]
+      args: ["hello from template"]
+`
+
+var dynamicTemplateRefWorkflow = `
+apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+  generateName: dynamic-workflow-
+spec:
+  entrypoint: whalesay
+  templates:
+  - name: whalesay
+    steps:
+      - - name: whalesay
+          templateRef:
+            name: workflow-template-a
+            template: template-a
+          arguments:
+            parameters:
+              - name: message
+                value: "template-b"
+`
+
+func TestDynamicWorkflowTemplateRef(t *testing.T) {
+	ctx := logging.TestContext(t.Context())
+	wf := wfv1.MustUnmarshalWorkflow(dynamicTemplateRefWorkflow)
+	wftmplA := wfv1.MustUnmarshalWorkflowTemplate(dynamicWorkflowTemplateARefB)
+	wftmplB := wfv1.MustUnmarshalWorkflowTemplate(dynamicWorkflowTemplateRefB)
+
+	err := createWorkflowTemplate(ctx, wftmplA)
+	require.NoError(t, err)
+	err = createWorkflowTemplate(ctx, wftmplB)
+	require.NoError(t, err)
+
+	err = ValidateWorkflow(ctx, wftmplGetter, cwftmplGetter, wf, nil, ValidateOpts{})
+	require.NoError(t, err)
+
+	_ = deleteWorkflowTemplate(ctx, wftmplA.Name)
+	_ = deleteWorkflowTemplate(ctx, wftmplB.Name)
+}