chore: rename IsWorkflowDeleted to WorkflowExists for clarity (argoproj#15146)

Signed-off-by: shuangkun <tsk2013uestc@163.com>

Author: shuangkun

workflow/controller/controller.go

@@ -427,7 +427,7 @@ func (wfc *WorkflowController) createSynchronizationManager(ctx context.Context)
 		wfc.wfQueue.AddAfter(key, semaphoreNotifyDelay)
 	}
 
-	isWFDeleted := func(key string) bool {
+	workflowExists := func(key string) bool {
 		_, exists, err := wfc.wfInformer.GetIndexer().GetByKey(key)
 		if err != nil {
 			logging.RequireLoggerFromContext(ctx).WithField("key", key).WithError(err).Error(ctx, "Failed to get workflow from informer")
@@ -436,7 +436,7 @@ func (wfc *WorkflowController) createSynchronizationManager(ctx context.Context)
 		return exists
 	}
 
-	wfc.syncManager = sync.NewLockManager(ctx, wfc.kubeclientset, wfc.namespace, wfc.Config.Synchronization, getSyncLimit, nextWorkflow, isWFDeleted)
+	wfc.syncManager = sync.NewLockManager(ctx, wfc.kubeclientset, wfc.namespace, wfc.Config.Synchronization, getSyncLimit, nextWorkflow, workflowExists)
 }
 
 // list all running workflows to initialize throttler and syncManager

workflow/sync/sync_manager.go

@@ -20,9 +20,9 @@ import (
 )
 
 type (
-	NextWorkflow      func(string)
-	GetSyncLimit      func(context.Context, string) (int, error)
-	IsWorkflowDeleted func(string) bool
+	NextWorkflow   func(string)
+	GetSyncLimit   func(context.Context, string) (int, error)
+	WorkflowExists func(string) bool
 )
 
 type Manager struct {
@@ -31,7 +31,7 @@ type Manager struct {
 	nextWorkflow      NextWorkflow
 	getSyncLimit      GetSyncLimit
 	syncLimitCacheTTL time.Duration
-	isWFDeleted       IsWorkflowDeleted
+	workflowExists    WorkflowExists
 	dbInfo            syncdb.DBInfo
 	queries           syncdb.SyncQueries
 	log               logging.Logger
@@ -44,11 +44,11 @@ const (
 	lockTypeMutex     lockTypeName = "mutex"
 )
 
-func NewLockManager(ctx context.Context, kubectlConfig kubernetes.Interface, namespace string, config *config.SyncConfig, getSyncLimit GetSyncLimit, nextWorkflow NextWorkflow, isWFDeleted IsWorkflowDeleted) *Manager {
-	return createLockManager(ctx, syncdb.DBSessionFromConfig(ctx, kubectlConfig, namespace, config), config, getSyncLimit, nextWorkflow, isWFDeleted)
+func NewLockManager(ctx context.Context, kubectlConfig kubernetes.Interface, namespace string, config *config.SyncConfig, getSyncLimit GetSyncLimit, nextWorkflow NextWorkflow, workflowExists WorkflowExists) *Manager {
+	return createLockManager(ctx, syncdb.DBSessionFromConfig(ctx, kubectlConfig, namespace, config), config, getSyncLimit, nextWorkflow, workflowExists)
 }
 
-func createLockManager(ctx context.Context, dbSession db.Session, config *config.SyncConfig, getSyncLimit GetSyncLimit, nextWorkflow NextWorkflow, isWFDeleted IsWorkflowDeleted) *Manager {
+func createLockManager(ctx context.Context, dbSession db.Session, config *config.SyncConfig, getSyncLimit GetSyncLimit, nextWorkflow NextWorkflow, workflowExists WorkflowExists) *Manager {
 	syncLimitCacheTTL := time.Duration(0)
 	if config != nil && config.SemaphoreLimitCacheSeconds != nil {
 		syncLimitCacheTTL = time.Duration(*config.SemaphoreLimitCacheSeconds) * time.Second
@@ -66,7 +66,7 @@ func createLockManager(ctx context.Context, dbSession db.Session, config *config
 		nextWorkflow:      nextWorkflow,
 		getSyncLimit:      getSyncLimit,
 		syncLimitCacheTTL: syncLimitCacheTTL,
-		isWFDeleted:       isWFDeleted,
+		workflowExists:    workflowExists,
 		dbInfo:            dbInfo,
 		queries:           syncdb.NewSyncQueries(dbSession, dbInfo.Config),
 		log:               log,
@@ -116,7 +116,7 @@ func (sm *Manager) CheckWorkflowExistence(ctx context.Context) {
 			if err != nil {
 				continue
 			}
-			if !sm.isWFDeleted(wfKey) {
+			if !sm.workflowExists(wfKey) {
 				lock.release(ctx, holderKeys)
 				if err := lock.removeFromQueue(ctx, holderKeys); err != nil {
 					sm.log.WithField("holderKeys", holderKeys).WithError(err).Warn(ctx, "failed to remove from queue")