[Snowcap] window:set_geometry() rule breaks borders

[litvinov-git]

Describe the bug

very apparent on the screenshot:

moving it manually with the default mouse bind immediately fixes the border, but not having to do that is very important for scratchpad automation

decorating only after set_geometry fixes it as well, but it would be good to have the freedom to use set_geometry after creation (Edit: sometimes that still doesnt help)

also, the problem of clients ignoring the rules( some clients ignore set_geometry completely.

i think it would be great to have an option to completely ignore all resizing requests from clients

Reproduction steps

configuration as below, press the keybind

Relevant parts of config

    local function center(window, wsize)
        local geo = {}
        local msize = window:output():logical_size()
        geo.x = msize.width / 2 - wsize.width / 2
        geo.width = wsize.width
        geo.y = msize.height / 2 - wsize.height / 2
        geo.height = wsize.height
        window:set_geometry(geo)
    end

    local special_tag_names = { "chatgpt", "whatsapp", "telegram" }
    local special_tags = Tag.add(Output.get_focused(), special_tag_names)
    local function toggle_special(name)
        local current_output = Output.get_focused()
        local tag = Tag.get(name)
        if tag:output():serial() ~= current_output:serial() then
            tag:move_to_output(current_output)
        end
        tag:switch_to()
        if #tag:windows() == 0 then
            Process.spawn("/home/vlitvinov/webapps/" .. name .. ".sh")
            tag:windows()[1]:set_floating(true)
        end
    end

    Input.keybind({ "alt" }, "z", function()
        toggle_special("whatsapp")
    end, {
        group = "Tag",
        description = "WhatsApp"
    })

    local function my_border(window)
        local proto = getmetatable(Snowcap.integration.focus_border(window)).__index

        local border = {
            window = window,
            thickness = 2,
            focused_color = from_hex("#b1acdb"),
            unfocused_color = Widget.color.from_rgba(0.15, 0.15, 0.15),
            focused = window:focused(),
            include_titlebar = false,
            title = "",
            titlebar_height = 0,
        }
        setmetatable(border, { __index = proto })
        return border
    end


    Window.add_window_rule(function(window)
        window:set_decoration_mode("server_side")
        my_border(window):decorate()
        window:set_maximized(false)
        window:set_fullscreen(false)
        if string.find(window:tags()[1]:name(), "%D") then
            window:set_floating(true)
            center(window, {width = 1000, height = 1000})
        end
    end)

Version info

pinnacle 0.2.3

Build Info:
Build profile: release
rustc version: 1.91.1
Branch: v0.2
Commit: b33d2fe (release: v0.2.3)

Distro

Arch

GPU

builtin intel

Config language

Lua

[Ph4ntomas]

Hello,

Could you reduce the example a bit? The config example does a bunch of things at once, part of it being your own code in some external scripts (nothing wrong with that, but it'd be easier to reproduce if it did not depends on your own scripts).
Do you know if it's reproducible when using WINIT/hosted mode (by starting pinnacle inside pinnacle)?
Do you know if it's app dependent?
Have you tried master to see if the bug still occurs?

It seems like we're missing a size update, but I couldn't reproduce the issue in winit (on the main branch at least) using alacritty.

[Ottatop]

Yea, a minimal reproducible example would be helpful. The border seems to update fine when spawning librewolf --kiosk, but idk what your shell script is doing.

From an initial look, a few things are suspect, though I doubt they're causing this issue:

•       if #tag:windows() == 0 then
            Process.spawn("/home/vlitvinov/webapps/" .. name .. ".sh")
            tag:windows()[1]:set_floating(true)
        end

  This assumes the window will exist directly after spawn returns, which it usually doesn't. This shouldn't matter for this issue though as the index error is caught when the keybind is pressed.

•   local function my_border(window)
        local proto = getmetatable(Snowcap.integration.focus_border(window)).__index
  
        local border = {
            window = window,
            thickness = 2,
            focused_color = from_hex("#b1acdb"),
            unfocused_color = Widget.color.from_rgba(0.15, 0.15, 0.15),
            focused = window:focused(),
            include_titlebar = false,
            title = "",
            titlebar_height = 0,
        }
        setmetatable(border, { __index = proto })
        return border
    end

  Don't really know why you're creating a new table and yoinking __index, but this crashes on latest main. You should be setting the fields instead.

i think it would be great to have an option to completely ignore all resizing requests from clients

That's not how Wayland works unfortunately. Clients get the final say in their size. The best we can do is clip them or warp their contents to fit.

[litvinov-git]

Yea, a minimal reproducible example would be helpful. The border seems to update fine when spawning librewolf --kiosk, but idk what your shell script is doing.

From an initial look, a few things are suspect, though I doubt they're causing this issue:

* if #tag:windows() == 0 then
            Process.spawn("/home/vlitvinov/webapps/" .. name .. ".sh")
            tag:windows()[1]:set_floating(true)
        end
      
        
      
  
        
      
  
      
    
  This assumes the window will exist directly after `spawn` returns, which it usually doesn't. This shouldn't matter for this issue though as the index error is caught when the keybind is pressed.

* local function my_border(window)
        local proto = getmetatable(Snowcap.integration.focus_border(window)).__index
  
        local border = {
            window = window,
            thickness = 2,
            focused_color = from_hex("#b1acdb"),
            unfocused_color = Widget.color.from_rgba(0.15, 0.15, 0.15),
            focused = window:focused(),
            include_titlebar = false,
            title = "",
            titlebar_height = 0,
        }
        setmetatable(border, { __index = proto })
        return border
    end
      
        
      
  
        
      
  
      
    
  Don't really know why you're creating a new table and yoinking `__index`, but this crashes on latest main. You should be setting the fields instead.

i think it would be great to have an option to completely ignore all resizing requests from clients

That's not how Wayland works unfortunately. Clients get the final say in their size. The best we can do is clip them or warp their contents to fit.

The scripts are all smth like this:

sh -c 'XAPP_FORCE_GTKWINDOW_ICON="/home/vlitvinov/.local/share/icons/icons8-chatgpt-100(1).png" env GDK_BACKEND=x11 MOZ_ENABLE_WAYLAND=0 firefox --class WebApp-ChatGPT6916 --name WebApp-ChatGPT6916 --profile /home/vlitvinov/.local/share/ice/firefox/ChatGPT6916 --no-remote "http://www.chatgpt.com"'

Basically this launches firefox in xwayland (env GDK_BACKEND=x11), which i think is likely to cause problems (i force xwayland to solve the titlebar problem)

The metatable yeah, my user error, though i dont think that it could cause the problem

About being able to ignore the requests... hyprland does it, as far as i know. I am really sorry for the constant hyprland this, hyprland that...
No idea how they do it though

This is all i can say now to narrow down the issue, i will think harder and maybe come up with something more helpful

[Ottatop]

Well when I run GDK_BACKEND=x11 firefox --kiosk google.com I get a completely undecorated window. Given that we don't know what firefox profiles you're using nor what else your config is doing we're going to need an MRE to figure it out.

[litvinov-git]

GDK_BACKEND=x11 firefox --kiosk google.com

i cant reproduce it now even with completely the same setup, my config broke randomly and the windows dont even start floating with the lua i posted in this issue, even though they did before