Skip to content

[Bug] Missing next-gen Grafana generation check for Grafana JSON changes #5010

@tenfyzhong

Description

@tenfyzhong

Description

The current PR workflow does not validate next-gen Grafana dashboard generation when a JSON file under metrics/grafana is modified.

make generate-next-gen-grafana is currently executed through make check, but the PR workflow excludes *.json changes from triggering that job. As a result, changes to files such as metrics/grafana/ticdc_new_arch.json can bypass the generation check, and stale generated dashboards under metrics/nextgengrafana may slip through CI.

Expected Behavior

When a JSON file under metrics/grafana is changed, CI should run the next-gen Grafana generation check and fail if the generated files are not updated.

Changes outside metrics/grafana should not trigger this check.

Proposed Solution

Split the next-gen Grafana generation check out of the general make check target and add a dedicated GitHub Actions workflow that runs only for metrics/grafana/*.json changes.

Metadata

Metadata

Assignees

Labels

type/enhancementThe issue or PR belongs to an enhancement.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions