-
Notifications
You must be signed in to change notification settings - Fork 52
Grafana stacked panels should render null values as zero #5009
Copy link
Copy link
Closed
Labels
component/metrics-loggingMetrics and logging component.Metrics and logging component.contributionThis PR is from a community contributor.This PR is from a community contributor.first-time-contributorIndicates that the PR was contributed by an external member and is a first-time contributor.Indicates that the PR was contributed by an external member and is a first-time contributor.type/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.
Metadata
Metadata
Assignees
Labels
component/metrics-loggingMetrics and logging component.Metrics and logging component.contributionThis PR is from a community contributor.This PR is from a community contributor.first-time-contributorIndicates that the PR was contributed by an external member and is a first-time contributor.Indicates that the PR was contributed by an external member and is a first-time contributor.type/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.
Problem
Some TiCDC Grafana dashboards use stacked graph panels. When a stacked panel keeps the default null handling (
nullPointMode: "null"), a single series with missing points can make the stacked visualization misleading or broken in Grafana.For stacked panels, null values should be rendered as zero so gaps in one series do not corrupt the visual stacking of the remaining series.
Affected dashboards
The current TiCDC fix touches:
metrics/grafana/ticdc_new_arch.jsonmetrics/nextgengrafana/ticdc_new_arch_next_gen.jsonExpected contract
For every legacy Grafana graph panel with stack enabled:
"stack": true"nullPointMode": "null as zero"Non-stacked panels should not be changed only because they have
nullPointMode.Related fix
PR: #5008
The PR updates stacked Grafana panels to render null values as zero and verifies the dashboard JSON structurally.