fix: eliminate double space when priority is not set#608
Open
AmSach wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug I found while browsing. The compact_multiple formatter was adding a space after the priority column even when no priority was set (empty string), causing double spacing between the todo ID and the due date. The fix uses conditional logic to only add the priority and its trailing space when the priority string is non-empty.
Before:
[{completed}] {todo.id} { } {due} ...(double space when no priority)After:
[{completed}] {todo.id} {due} ...(single space)Fixes the FIXME comment at formatters.py line 185. — Sent via @AmSach bot