Remove condition

Author: VincentLanglet

src/Type/Php/GetClassDynamicReturnTypeExtension.php

@@ -14,7 +14,6 @@
 use PHPStan\Type\Generic\GenericClassStringType;
 use PHPStan\Type\Generic\TemplateType;
 use PHPStan\Type\IntersectionType;
-use PHPStan\Type\ObjectShapeType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\ObjectWithoutClassType;
 use PHPStan\Type\StaticType;
@@ -67,10 +66,6 @@ static function (Type $type, callable $traverse): Type {
 					return new GenericClassStringType(new ObjectType($type->getClassName()));
 				}
 
-				if ($type instanceof ObjectShapeType) {
-					return new ClassStringType();
-				}
-
 				$isObject = $type->isObject();
 				if ($isObject->no()) {
 					return new ConstantBooleanType(false);

tests/PHPStan/Analyser/nsrt/bug-4890.php

@@ -46,8 +46,8 @@ public function updateProp(object $entity): void
 	 */
 	public function updateObjectShape($entity): void
 	{
-		assertType('class-string', get_class($entity));
+		assertType('class-string<object{foo: Bug4890\HelloWorld, bar: int, baz?: string}>', get_class($entity));
 		assert(property_exists($entity, 'foo'));
-		assertType('class-string', get_class($entity));
+		assertType('class-string<object{foo: Bug4890\HelloWorld, bar: int, baz?: string}>', get_class($entity));
 	}
 }