Warn about incomplete versions in #[RequiresPhp]

Author: staabm

src/Rules/PHPUnit/AttributeRequiresPhpVersionRule.php

@@ -33,22 +33,28 @@ class AttributeRequiresPhpVersionRule implements Rule
 	private TestMethodsHelper $testMethodsHelper;
 
 	/**
-	 * When phpstan-deprecation-rules is installed, it reports deprecated usages.
+	 * When phpstan-deprecation-rules is installed, rule reports deprecated usages.
 	 */
 	private bool $deprecationRulesInstalled;
 
+	/**
+	 * Whether warnings about incomplete versions are allowed to be emitted
+	 */
+	private bool $warnAboutIncompleteVersion;
+
 	public function __construct(
 		PHPUnitVersion $PHPUnitVersion,
 		TestMethodsHelper $testMethodsHelper,
 		bool $deprecationRulesInstalled,
-		PhpVersion $phpVersion
+		PhpVersion $phpVersion,
+		bool $warnAboutIncompleteVersion = true
 	)
 	{
 		$this->PHPUnitVersion = $PHPUnitVersion;
 		$this->testMethodsHelper = $testMethodsHelper;
 		$this->deprecationRulesInstalled = $deprecationRulesInstalled;
-
 		$this->phpstanPhpVersion = new Version($phpVersion->getVersionString());
+		$this->warnAboutIncompleteVersion = $warnAboutIncompleteVersion;
 	}
 
 	public function getNodeType(): string
@@ -80,6 +86,15 @@ public function processNode(Node $node, Scope $scope): array
 			// see https://github.com/sebastianbergmann/phpunit/blob/43c2cd7b96ee1e800b35e4df23b419a88b53111d/src/Metadata/Version/Requirement.php
 
 			$versionRequirement = $args[0];
+
+			if ($this->warnAboutIncompleteVersion($versionRequirement)) {
+				$errors[] = RuleErrorBuilder::message(
+					sprintf('Version requirement is incomplete.'),
+				)
+					->identifier('phpunit.incompletePhpVersion')
+					->build();
+			}
+
 			if (
 				!is_numeric($versionRequirement)
 			) {
@@ -139,4 +154,18 @@ public function processNode(Node $node, Scope $scope): array
 		return $errors;
 	}
 
+	// see https://github.com/sebastianbergmann/phpunit/issues/6451
+	function warnAboutIncompleteVersion(string $versionRequirement): bool
+	{
+		if (!$this->warnAboutIncompleteVersion) {
+			return false;
+		}
+
+		if (!$this->PHPUnitVersion->warnsAboutIncompleteVersion()->yes()) {
+			return false;
+		}
+
+		return substr_count($versionRequirement, '.') !== 2;
+	}
+
 }

src/Rules/PHPUnit/PHPUnitVersion.php

@@ -62,6 +62,11 @@ public function deprecatesPhpversionAttributeWithoutOperator(): TrinaryLogic
 		return $this->minVersion(12, 4);
 	}
 
+	public function warnsAboutIncompleteVersion(): TrinaryLogic
+	{
+		return $this->minVersion(12, 5);
+	}
+
 	private function minVersion(int $major, int $minor): TrinaryLogic
 	{
 		if ($this->majorVersion === null || $this->minorVersion === null) {

tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php

@@ -21,6 +21,8 @@ final class AttributeRequiresPhpVersionRuleTest extends RuleTestCase
 
 	private bool $deprecationRulesInstalled = true;
 
+	private bool $warnAboutIncompleteVersion = false;
+
 	public function testRuleOnPHPUnitUnknown(): void
 	{
 		$this->phpunitMajorVersion = null;
@@ -137,6 +139,35 @@ public function testInvalidPhpVersion(): void
 		]);
 	}
 
+	public function testNoWarnAboutIncompleteVersionInOldPhpunit(): void
+	{
+		$this->phpunitMajorVersion = 12;
+		$this->phpunitMinorVersion = 0;
+		$this->deprecationRulesInstalled = false;
+		$this->warnAboutIncompleteVersion = true;
+
+		$this->analyse([__DIR__ . '/data/requires-php-version.php'], []);
+	}
+
+	public function testWarnAboutIncompleteVersion(): void
+	{
+		$this->phpunitMajorVersion = 12;
+		$this->phpunitMinorVersion = 5;
+		$this->deprecationRulesInstalled = false;
+		$this->warnAboutIncompleteVersion = true;
+
+		$this->analyse([__DIR__ . '/data/requires-php-version.php'], [
+			[
+				'Version requirement is incomplete.',
+				12,
+			],
+			[
+				'Version requirement is incomplete.',
+				20,
+			],
+		]);
+	}
+
 	protected function getRule(): Rule
 	{
 		$phpunitVersion = new PHPUnitVersion($this->phpunitMajorVersion, $this->phpunitMinorVersion);
@@ -149,6 +180,7 @@ protected function getRule(): Rule
 			),
 			$this->deprecationRulesInstalled,
 			new PhpVersion($this->phpVersion),
+			$this->warnAboutIncompleteVersion
 		);
 	}