Add accessibility

Author: veewee

phpunit.xml

@@ -16,6 +16,7 @@
     <testsuites>
         <testsuite name="default">
             <directory>tests</directory>
+            <exclude>tests/Result/AbstractResultTest.php</exclude>
         </testsuite>
     </testsuites>
 

src/Any.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-
 namespace Phpro\AgentRules;
 
 /**

src/Either.php

@@ -2,11 +2,8 @@
 
 declare(strict_types=1);
 
-
 namespace Phpro\AgentRules;
 
-
-
 /**
  * @template T
  *

src/Result/AbstractResult.php

@@ -4,6 +4,7 @@
 
 namespace Phpro\AgentRules\Result;
 
+use Phpro\AgentRules\Source\Source;
 use Phpro\AgentRules\Source\SourceMap;
 
 abstract readonly class AbstractResult implements ResultInterface
@@ -21,6 +22,13 @@ public function sources(): SourceMap
         return $this->sources;
     }
 
+    public function addSources(Source ...$sources): static
+    {
+        $this->sources->add(...$sources);
+
+        return $this;
+    }
+
     #[\Override]
     public function jsonSerialize(): array
     {

src/Result/ResultInterface.php

@@ -2,10 +2,8 @@
 
 declare(strict_types=1);
 
-
 namespace Phpro\AgentRules\Result;
 
-
 use Phpro\AgentRules\Source\SourceMap;
 
 interface ResultInterface extends \JsonSerializable

src/RuleEngine.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-
 namespace Phpro\AgentRules;
 
 /**

src/RuleInterface.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-
 namespace Phpro\AgentRules;
 
 /**

src/RulesAnalyzer.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-
 namespace Phpro\AgentRules;
 
 use Psl\Graph;

src/Sequence.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-
 namespace Phpro\AgentRules;
 
 /**

tests/Result/CompleteResultTest.php tests/Result/AbstractResultTestCase.phptests/Result/CompleteResultTest.php renamed to tests/Result/AbstractResultTestCase.php

@@ -4,48 +4,28 @@
 
 namespace Phpro\AgentRules\Tests\Result;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
-use Phpro\AgentRules\Result\CompleteResult;
+use Phpro\AgentRules\Result\ResultInterface;
 use Phpro\AgentRules\Source\Source;
 
-#[CoversClass(CompleteResult::class)]
-final class CompleteResultTest extends TestCase
+abstract class AbstractResultTestCase extends TestCase
 {
-    #[Test]
-    public function it_returns_complete_status(): void
-    {
-        $result = new CompleteResult('Task completed');
-
-        static::assertSame('complete', $result->getStatus());
-    }
-
-    #[Test]
-    public function it_includes_message_in_json_serialization(): void
-    {
-        $result = new CompleteResult('Task completed successfully');
+    abstract protected function createResult(): ResultInterface;
 
-        $serialized = $result->jsonSerialize();
-
-        static::assertSame('complete', $serialized['status']);
-        static::assertSame('Task completed successfully', $serialized['message']);
-    }
+    abstract protected function expectedStatus(): string;
 
-    #[Test]
-    public function it_returns_empty_source_map(): void
+    public function test_it_returns_empty_source_map(): void
     {
-        $result = new CompleteResult('Task completed');
+        $result = $this->createResult();
 
         $sources = $result->sources()->sources();
 
         static::assertCount(0, $sources);
     }
 
-    #[Test]
-    public function it_can_add_sources_to_result(): void
+    public function test_it_can_add_sources_to_result(): void
     {
-        $result = new CompleteResult('Task completed');
+        $result = $this->createResult();
         $source = new Source('Documentation', 'https://docs.example.com', 'See the docs for more info');
 
         $result->sources()->add($source);
@@ -57,10 +37,9 @@ public function it_can_add_sources_to_result(): void
         static::assertSame('See the docs for more info', $sources[0]->content);
     }
 
-    #[Test]
-    public function it_includes_sources_in_json_serialization(): void
+    public function test_it_includes_sources_in_json_serialization(): void
     {
-        $result = new CompleteResult('Task completed');
+        $result = $this->createResult();
         $result->sources()->add(
             new Source('Docs', 'https://docs.example.com', 'See docs'),
             new Source('Help', 'https://help.example.com', 'Need help')
@@ -76,4 +55,27 @@ public function it_includes_sources_in_json_serialization(): void
         static::assertSame('See docs', $data['sources'][0]['content']);
         static::assertSame('Help', $data['sources'][1]['name']);
     }
+
+    public function test_it_can_add_multiple_sources_at_once(): void
+    {
+        $result = $this->createResult();
+
+        $returnValue = $result->addSources(
+            new Source('API', 'https://api.example.com', 'API docs'),
+            new Source('Guide', 'https://guide.example.com', 'User guide'),
+            new Source('FAQ', 'https://faq.example.com', 'Frequently asked')
+        );
+
+        static::assertSame($result, $returnValue);
+        static::assertCount(3, $result->sources()->sources());
+    }
+
+    public function test_it_includes_status_in_json_serialization(): void
+    {
+        $result = $this->createResult();
+
+        $serialized = $result->jsonSerialize();
+
+        static::assertSame($this->expectedStatus(), $serialized['status']);
+    }
 }