tidy: reduce cyclomatic complexity

Author: Greg Bowler

src/DataObject.php

@@ -117,34 +117,60 @@ public function asObject():object {
 	 * @param array<mixed> $array
 	 * @return array<mixed>
 	 */
-	private function checkArrayType(array $array, string $type):array {
-		$errorMessage = "";
+	private function checkArrayType(array $array, string $type): array {
+		$this->validateTypeExists($type);
 
-		foreach($array as $i => $value) {
-			$actualType = is_scalar($value) ? gettype($value) : get_class($value);
+		foreach ($array as $i => $value) {
+			$array[$i] = $this->processValue($value, $type, $i);
+		}
 
-			if(class_exists($type) || interface_exists($type)) {
-				if(!is_a($value, $type)) {
-					$errorMessage = "Array index $i must be of type $type, $actualType given";
-				}
-			}
-			elseif(function_exists("is_$type")) {
-				$castedValue = match($type) {
-					"int" => (int)$value,
-					"bool" => (bool)$value,
-					"string" => (string)$value,
-					"float", "double" => (float)$value,
-					"array" => (array)$value,
-					default => null,
-				};
-				$array[$i] = $castedValue;
-			}
+		return $array;
+	}
+
+	private function validateTypeExists(string $type): void {
+		if(!class_exists($type)
+		&& !interface_exists($type)
+		&& !function_exists("is_$type")) {
+			throw new TypeError("Invalid type: $type does not exist.");
 		}
+	}
 
-		if($errorMessage) {
-			throw new TypeError($errorMessage);
+	private function processValue(
+		mixed $value,
+		string $type,
+		int $index,
+	): mixed {
+		if (class_exists($type) || interface_exists($type)) {
+			$this->assertInstanceOfType($value, $type, $index);
+		} elseif (function_exists("is_$type")) {
+			return $this->castValue($value, $type);
 		}
 
-		return $array;
+		return $value;
+	}
+
+	private function assertInstanceOfType(
+		mixed $value,
+		string $type,
+		int $index,
+	): void {
+		if (!is_a($value, $type)) {
+			$actualType = is_scalar($value)
+				? gettype($value)
+				: get_class($value);
+			throw new TypeError("Array index $index"
+				. " must be of type $type, $actualType given");
+		}
+	}
+
+	private function castValue(mixed $value, string $type): mixed {
+		return match ($type) {
+			"int" => (int)$value,
+			"bool" => (bool)$value,
+			"string" => (string)$value,
+			"float", "double" => (float)$value,
+			"array" => (array)$value,
+			default => null,
+		};
 	}
 }