[TASK] Use static:: instead of self:: (#47)

This will allow for subclasses to overwrite methods and constants and hence
is the current recommended practice.

Author: oliverklee

Tests/Integration/Composer/ScriptsTest.php

@@ -17,7 +17,7 @@ class ScriptsTest extends TestCase
      */
     public function webDirectoryHasBeenCreated()
     {
-        self::assertDirectoryExists($this->getAbsoluteWebDirectoryPath());
+        static::assertDirectoryExists($this->getAbsoluteWebDirectoryPath());
     }
 
     /**
@@ -48,15 +48,15 @@ public function webDirectoryFilesDataProvider(): array
      */
     public function webDirectoryFilesExist(string $fileName)
     {
-        self::assertFileExists($this->getAbsoluteWebDirectoryPath() . $fileName);
+        static::assertFileExists($this->getAbsoluteWebDirectoryPath() . $fileName);
     }
 
     /**
      * @test
      */
     public function binariesDirectoryHasBeenCreated()
     {
-        self::assertDirectoryExists($this->getAbsoluteBinariesDirectoryPath());
+        static::assertDirectoryExists($this->getAbsoluteBinariesDirectoryPath());
     }
 
     /**
@@ -84,7 +84,7 @@ public function binariesDataProvider(): array
      */
     public function binariesExist(string $fileName)
     {
-        self::assertFileExists($this->getAbsoluteBinariesDirectoryPath() . $fileName);
+        static::assertFileExists($this->getAbsoluteBinariesDirectoryPath() . $fileName);
     }
 
     /**
@@ -100,7 +100,7 @@ private function getBundleConfigurationFilePath(): string
      */
     public function bundleConfigurationFileExists()
     {
-        self::assertFileExists($this->getBundleConfigurationFilePath());
+        static::assertFileExists($this->getBundleConfigurationFilePath());
     }
 
     /**
@@ -122,7 +122,7 @@ public function bundleConfigurationFileContainsModuleBundles(string $bundleClass
     {
         $fileContents = file_get_contents($this->getBundleConfigurationFilePath());
 
-        self::assertContains($bundleClassName, $fileContents);
+        static::assertContains($bundleClassName, $fileContents);
     }
 
     /**
@@ -138,22 +138,22 @@ private function getModuleRoutesConfigurationFilePath(): string
      */
     public function moduleRoutesConfigurationFileExists()
     {
-        self::assertFileExists($this->getModuleRoutesConfigurationFilePath());
+        static::assertFileExists($this->getModuleRoutesConfigurationFilePath());
     }
 
     /**
      * @test
      */
     public function parametersConfigurationFileExists()
     {
-        self::assertFileExists(dirname(__DIR__, 3) . '/Configuration/parameters.yml');
+        static::assertFileExists(dirname(__DIR__, 3) . '/Configuration/parameters.yml');
     }
 
     /**
      * @test
      */
     public function modulesConfigurationFileExists()
     {
-        self::assertFileExists(dirname(__DIR__, 3) . '/Configuration/config_modules.yml');
+        static::assertFileExists(dirname(__DIR__, 3) . '/Configuration/config_modules.yml');
     }
 }

Tests/System/ApplicationBundle/PhpListApplicationBundleTest.php

@@ -53,7 +53,7 @@ public function homepageReturnsSuccess(string $environment)
 
         $response = $this->httpClient->get('/', ['base_uri' => $this->getBaseUrl()]);
 
-        self::assertSame(200, $response->getStatusCode());
+        static::assertSame(200, $response->getStatusCode());
     }
 
     /**
@@ -67,6 +67,6 @@ public function homepageReturnsContent(string $environment)
 
         $response = $this->httpClient->get('/', ['base_uri' => $this->getBaseUrl()]);
 
-        self::assertNotEmpty($response->getBody()->getContents());
+        static::assertNotEmpty($response->getBody()->getContents());
     }
 }