[TASK] Let Directives with no node inherit form ActionDirective

We have had ActionDirective since a while but didn't apply it to older existing directives

Author: linawolf

packages/guides-restructured-text/src/RestructuredText/Directives/MetaDirective.php

@@ -5,7 +5,6 @@
 namespace phpDocumentor\Guides\RestructuredText\Directives;
 
 use phpDocumentor\Guides\Nodes\Metadata\MetaNode;
-use phpDocumentor\Guides\Nodes\Node;
 use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
 
@@ -15,24 +14,19 @@
  * .. meta::
  *      :key: value
  */
-class MetaDirective extends BaseDirective
+class MetaDirective extends ActionDirective
 {
     public function getName(): string
     {
         return 'meta';
     }
 
-    /** {@inheritDoc} */
-    public function process(
-        BlockContext $blockContext,
-        Directive $directive,
-    ): Node|null {
+    public function processAction(BlockContext $blockContext, Directive $directive): void
+    {
         $document = $blockContext->getDocumentParserContext()->getDocument();
 
         foreach ($directive->getOptions() as $option) {
             $document->addHeaderNode(new MetaNode($option->getName(), (string) $option->getValue()));
         }
-
-        return null;
     }
 }

packages/guides-restructured-text/src/RestructuredText/Directives/TitleDirective.php

@@ -4,7 +4,6 @@
 
 namespace phpDocumentor\Guides\RestructuredText\Directives;
 
-use phpDocumentor\Guides\Nodes\Node;
 use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
 
@@ -13,21 +12,16 @@
  *
  * .. title:: Page title
  */
-class TitleDirective extends BaseDirective
+class TitleDirective extends ActionDirective
 {
     public function getName(): string
     {
         return 'title';
     }
 
-    /** {@inheritDoc} */
-    public function process(
-        BlockContext $blockContext,
-        Directive $directive,
-    ): Node|null {
+    public function processAction(BlockContext $blockContext, Directive $directive): void
+    {
         $document = $blockContext->getDocumentParserContext()->getDocument();
         $document->setMetaTitle($directive->getData());
-
-        return null;
     }
 }

packages/guides-restructured-text/src/RestructuredText/Directives/TodoDirective.php

@@ -4,24 +4,21 @@
 
 namespace phpDocumentor\Guides\RestructuredText\Directives;
 
-use phpDocumentor\Guides\Nodes\CollectionNode;
-use phpDocumentor\Guides\Nodes\Node;
+use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
 
 /**
  * Todo directives are treated as comments, omitting all content or options
  */
-class TodoDirective extends SubDirective
+class TodoDirective extends ActionDirective
 {
     public function getName(): string
     {
         return 'todo';
     }
 
-    protected function processSub(
-        CollectionNode $collectionNode,
-        Directive $directive,
-    ): Node|null {
-        return null;
+    public function processAction(BlockContext $blockContext, Directive $directive): void
+    {
+        // Todo directives are treated as comments
     }
 }