Prefer posix_spawn_file_actions_addchdir() over _np variant when available #20647
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 5, 2025
devnexen
approved these changes
Dec 5, 2025
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
the change itself is good, regardless of the deprecation, standard is better over non portable (_np) versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On recent macOS SDKs
posix_spawn_file_actions_addchdir_np()is declared as deprecated and triggers a -Werror,-Wdeprecated-declarations build failure when compilingext/standard/proc_open.c. The deprecation notice explicitly recommends using the standardizedposix_spawn_file_actions_addchdir()function instead.This patch makes
proc_open()prefer the standard POSIX function when it is available, while keeping the existing _np behavior as a fallback.