main/output.c: use RETURN_BOOL() when possible

Girgias · Girgias · commit e0c3cc6ca45d · 2025-11-29T13:49:40.000Z
diff --git a/main/output.c b/main/output.c
@@ -1593,11 +1593,7 @@ PHP_FUNCTION(output_reset_rewrite_vars)
 		RETURN_THROWS();
 	}
 
-	if (php_url_scanner_reset_vars() == SUCCESS) {
-		RETURN_TRUE;
-	} else {
-		RETURN_FALSE;
-	}
+	RETURN_BOOL(php_url_scanner_reset_vars() == SUCCESS);
 }
 /* }}} */
 
@@ -1611,10 +1607,6 @@ PHP_FUNCTION(output_add_rewrite_var)
 		RETURN_THROWS();
 	}
 
-	if (php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS) {
-		RETURN_TRUE;
-	} else {
-		RETURN_FALSE;
-	}
+	RETURN_BOOL(php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS);
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -1593,11 +1593,7 @@ PHP_FUNCTION(output_reset_rewrite_vars)`
`1593`	`1593`	`RETURN_THROWS();`
`1594`	`1594`	`}`
`1595`	`1595`
`1596`		`- if (php_url_scanner_reset_vars() == SUCCESS) {`
`1597`		`- RETURN_TRUE;`
`1598`		`- } else {`
`1599`		`- RETURN_FALSE;`
`1600`		`- }`
	`1596`	`+ RETURN_BOOL(php_url_scanner_reset_vars() == SUCCESS);`
`1601`	`1597`	`}`
`1602`	`1598`	`/* }}} */`
`1603`	`1599`
`@@ -1611,10 +1607,6 @@ PHP_FUNCTION(output_add_rewrite_var)`
`1611`	`1607`	`RETURN_THROWS();`
`1612`	`1608`	`}`
`1613`	`1609`
`1614`		`- if (php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS) {`
`1615`		`- RETURN_TRUE;`
`1616`		`- } else {`
`1617`		`- RETURN_FALSE;`
`1618`		`- }`
	`1610`	`+ RETURN_BOOL(php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS);`
`1619`	`1611`	`}`
`1620`	`1612`	`/* }}} */`