address comment

devnexen · devnexen · commit 806813f4c06b · 2026-02-23T12:41:19.000Z
diff --git a/ext/pcntl/pcntl.c b/ext/pcntl/pcntl.c
@@ -798,7 +798,7 @@ PHP_FUNCTION(pcntl_signal)
 		RETURN_THROWS();
 	}
 
-	/* we need to register in the OS side first before we update the internal list */
+	/* Register with the OS first so that on failure we don't record a handler that was never installed */
 	if (php_signal4(signo, pcntl_signal_handler, (int) restart_syscalls, 1) == (void *)SIG_ERR) {
 		PCNTL_G(last_error) = errno;
 		php_error_docref(NULL, E_WARNING, "Error assigning signal");

Original file line number	Diff line number	Diff line change
`@@ -798,7 +798,7 @@ PHP_FUNCTION(pcntl_signal)`
`798`	`798`	`RETURN_THROWS();`
`799`	`799`	`}`
`800`	`800`
`801`		`- /* we need to register in the OS side first before we update the internal list */`
	`801`	`+ /* Register with the OS first so that on failure we don't record a handler that was never installed */`
`802`	`802`	`if (php_signal4(signo, pcntl_signal_handler, (int) restart_syscalls, 1) == (void *)SIG_ERR) {`
`803`	`803`	`PCNTL_G(last_error) = errno;`
`804`	`804`	`php_error_docref(NULL, E_WARNING, "Error assigning signal");`