ext/pcre: preg_match() fix memory leak with invalid regexes.

devnexen · devnexen · commit 53f8369e6f80 · 2026-02-24T20:58:01.000Z
diff --git a/ext/pcre/php_pcre.c b/ext/pcre/php_pcre.c
@@ -1489,7 +1489,8 @@ ZEND_FRAMELESS_FUNCTION(preg_match, 2)
 	/* Compile regex or get it from cache. */
 	pcre_cache_entry *pce;
 	if ((pce = pcre_get_compiled_regex_cache(regex)) == NULL) {
-		RETURN_FALSE;
+		RETVAL_FALSE;
+		goto flf_clean;
 	}
 
 	pce->refcount++;

Original file line number	Diff line number	Diff line change
`@@ -1489,7 +1489,8 @@ ZEND_FRAMELESS_FUNCTION(preg_match, 2)`
`1489`	`1489`	`/* Compile regex or get it from cache. */`
`1490`	`1490`	`pcre_cache_entry *pce;`
`1491`	`1491`	`if ((pce = pcre_get_compiled_regex_cache(regex)) == NULL) {`
`1492`		`- RETURN_FALSE;`
	`1492`	`+ RETVAL_FALSE;`
	`1493`	`+ goto flf_clean;`
`1493`	`1494`	`}`
`1494`	`1495`
`1495`	`1496`	`pce->refcount++;`