ext/pcntl: Fix cpuset leak in pcntl_setcpuaffinity on out-of-range CPU ID

devnexen · devnexen · commit 37ce67f27699 · 2026-02-22T19:57:19.000Z
Add missing PCNTL_CPU_DESTROY(mask) call before RETURN_THROWS() when the cpu id is out of range, matching the cleanup on other error paths. close GH-21268
diff --git a/NEWS b/NEWS
@@ -44,6 +44,8 @@ PHP                                                                        NEWS
 - PCNTL:
   . Fixed pcntl_setns() internal errors handling regarding errnos.
     (David Carlier)
+  . Fixed cpuset leak in pcntl_setcpuaffinity on out-of-range CPU ID
+    on NetBSD/Solaris platforms. (David Carlier)
 
 - PDO_PGSQL:
   . Fixed bug GH-21055 (connection attribute status typo for GSS negotiation).
diff --git a/ext/pcntl/pcntl.c b/ext/pcntl/pcntl.c
@@ -1734,6 +1734,7 @@ PHP_FUNCTION(pcntl_setcpuaffinity)
 
 		if (cpu < 0 || cpu >= maxcpus) {
 			zend_argument_value_error(2, "cpu id must be between 0 and " ZEND_ULONG_FMT " (" ZEND_LONG_FMT ")", maxcpus, cpu);
+			PCNTL_CPU_DESTROY(mask);
 			RETURN_THROWS();
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1734,6 +1734,7 @@ PHP_FUNCTION(pcntl_setcpuaffinity)`
`1734`	`1734`
`1735`	`1735`	`if (cpu < 0 \|\| cpu >= maxcpus) {`
`1736`	`1736`	`zend_argument_value_error(2, "cpu id must be between 0 and " ZEND_ULONG_FMT " (" ZEND_LONG_FMT ")", maxcpus, cpu);`
	`1737`	`+ PCNTL_CPU_DESTROY(mask);`
`1737`	`1738`	`RETURN_THROWS();`
`1738`	`1739`	`}`
`1739`	`1740`