Skip to content

Commit 1bab302

Browse files
author
Christian Schneider
committed
Add missing arg_info doc_comment handling for accelerator/persist
1 parent 6d13363 commit 1bab302

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

ext/opcache/ZendAccelerator.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -677,6 +677,7 @@ static void accel_copy_permanent_strings(zend_new_interned_string_func_t new_int
677677
if (arg_info[i].default_value) {
678678
arg_info[i].default_value = new_interned_string(arg_info[i].default_value);
679679
}
680+
arg_info[i].doc_comment = new_interned_string(arg_info[i].doc_comment);
680681
}
681682
accel_copy_permanent_list_types(new_interned_string, arg_info[i].type);
682683
}

ext/opcache/zend_persist.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -652,6 +652,9 @@ static void zend_persist_op_array_ex(zend_op_array *op_array, zend_persistent_sc
652652
zend_accel_store_interned_string(arg_info[i].name);
653653
}
654654
zend_persist_type(&arg_info[i].type);
655+
if (arg_info[i].doc_comment) {
656+
zend_accel_store_interned_string(arg_info[i].doc_comment);
657+
}
655658
}
656659
if (op_array->fn_flags & ZEND_ACC_HAS_RETURN_TYPE) {
657660
arg_info++;

ext/opcache/zend_persist_calc.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,9 @@ static void zend_persist_op_array_calc_ex(zend_op_array *op_array)
306306
ADD_INTERNED_STRING(arg_info[i].name);
307307
}
308308
zend_persist_type_calc(&arg_info[i].type);
309+
if (arg_info[i].doc_comment) {
310+
ADD_INTERNED_STRING(arg_info[i].doc_comment);
311+
}
309312
}
310313
}
311314

0 commit comments

Comments
 (0)