bug: js error use own object extends HTMLElement (#493)

* bug: js error use own object extends HTMLElement

* refac: remove unnecessary phpdoc

* refac: remove old sf 4 stuff

Author: gimler

EventListener/AutoAddMissingTranslations.php

@@ -11,7 +11,6 @@
 
 namespace Translation\Bundle\EventListener;
 
-use Symfony\Component\HttpKernel\Event\PostResponseEvent;
 use Symfony\Component\HttpKernel\Event\TerminateEvent;
 use Symfony\Component\Translation\DataCollectorTranslator;
 use Translation\Bundle\Service\StorageService;
@@ -32,9 +31,6 @@ final class AutoAddMissingTranslations
      */
     private $storage;
 
-    /**
-     * @param DataCollectorTranslator $translator
-     */
     public function __construct(StorageService $storage, DataCollectorTranslator $translator = null)
     {
         $this->dataCollector = $translator;
@@ -56,10 +52,3 @@ public function onTerminate(TerminateEvent $event): void
         }
     }
 }
-
-// PostResponseEvent have been renamed into ResponseEvent in sf 4.3
-// @see https://github.com/symfony/symfony/blob/master/UPGRADE-4.3.md#httpkernel
-// To be removed once sf ^4.3 become the minimum supported version.
-if (!class_exists(TerminateEvent::class) && class_exists(PostResponseEvent::class)) {
-    class_alias(PostResponseEvent::class, TerminateEvent::class);
-}

EventListener/EditInPlaceResponseListener.php

@@ -12,7 +12,6 @@
 namespace Translation\Bundle\EventListener;
 
 use Symfony\Component\Asset\Packages;
-use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
 use Symfony\Component\HttpKernel\Event\ResponseEvent;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Translation\Bundle\EditInPlace\ActivatorInterface;
@@ -128,10 +127,3 @@ public function onKernelResponse(ResponseEvent $event): void
         $event->getResponse()->setContent($content);
     }
 }
-
-// FilterResponseEvent have been renamed into ResponseEvent in sf 4.3
-// @see https://github.com/symfony/symfony/blob/master/UPGRADE-4.3.md#httpkernel
-// To be removed once sf ^4.3 become the minimum supported version.
-if (!class_exists(ResponseEvent::class) && class_exists(FilterResponseEvent::class)) {
-    class_alias(FilterResponseEvent::class, ResponseEvent::class);
-}

Resources/public/js/editInPlace.js

@@ -8,7 +8,10 @@
  */
 (function () {
     if (typeof customElements.define !== "undefined") {
-        customElements.define("x-trans", HTMLElement);
+        // it is not possible to use HTMLElement directly
+        class XTrans extends HTMLElement {}
+
+        customElements.define("x-trans", XTrans);
 
         return;
     }