Skip to content

Commit 496c550

Browse files
lsvNyholm
authored andcommitted
Feature/webui overview (#172)
* Sorting message files, so they are similar on all languages * Moved message count from controller to twig, due to it affected the total count, Some more details * Cleaned up the total check
1 parent 0f096c7 commit 496c550

File tree

2 files changed

+30
-10
lines changed

2 files changed

+30
-10
lines changed

Controller/WebUIController.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@ public function indexAction($configName = null)
5858
ksort($domains);
5959
$catalogueSize[$locale] = 0;
6060
foreach ($domains as $domain => $messages) {
61-
$count = count(array_filter($messages, function ($message) {
62-
return '' !== $message;
63-
}));
61+
$count = count($messages);
6462
$catalogueSize[$locale] += $count;
6563
if (!isset($maxDomainSize[$domain]) || $count > $maxDomainSize[$domain]) {
6664
$maxDomainSize[$domain] = $count;

Resources/views/WebUI/index.html.twig

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,18 @@
88
<div class="catalouge">
99
<h3>{{ localeMap[cataloge.locale] }}</h3>
1010
<table class="domain-table">
11-
{% for domain,messages in cataloge.all %}
12-
{% set pg = maxDomainSize[domain] %}
13-
{% if pg > 0 %}
14-
{% set pg = (pg/messages|length)|round(2)*100 %}
11+
{% set totalMessages = 0 %}
12+
{% set translatedMessages = 0 %}
13+
{% for domain,messages in cataloge.all|sort %}
14+
{% set pg = 0 %}
15+
{% set translated = 0 %}
16+
{% for message in messages %}
17+
{% if message != '' %}
18+
{% set translated = translated + 1 %}
19+
{% endif %}
20+
{% endfor %}
21+
{% if translated > 0 %}
22+
{% set pg = (translated/messages|length*100)|round(2) %}
1523
{% endif %}
1624
<tr>
1725
<td>
@@ -23,13 +31,27 @@
2331
{{ macro.progress(pg, "") }}
2432
</td>
2533
<td>
26-
{{ pg }} %
34+
<small>({{ translated }} / {{ messages|length }})</small>
35+
<b>{{ pg }} %</b>
2736
</td>
2837
</tr>
38+
{% set totalMessages = totalMessages + messages|length %}
39+
{% set translatedMessages = translatedMessages + translated %}
2940
{% endfor %}
3041
</table>
31-
{% set pg = (100*catalogueSize[cataloge.locale]/maxCatalogueSize)|round %}
32-
<div class="text-xs-center">Total progress for this language: {{ pg }}%</div>
42+
{% if totalMessages == 0 %}
43+
{% set pg = 100 %}
44+
{% elseif translatedMessages > 0 and totalMessages > 0 %}
45+
{% set pg = (translatedMessages/totalMessages*100)|round(2) %}
46+
{% else %}
47+
{% set pg = 0 %}
48+
{% endif %}
49+
50+
<div class="text-xs-center">
51+
Total progress for this language:
52+
<small>({{ translatedMessages }} / {{ totalMessages }})</small>
53+
<b>{{ pg }}%</b>
54+
</div>
3355
{{ macro.progress(pg, "total-progressbar") }}
3456
</div>
3557
{% endfor %}

0 commit comments

Comments
 (0)