Feature/command obsolete (#173)

* Setting the php_translation.storage.default to public

* Updated obsolete command, with some more debug if needed, and dont ask if no messages are obsolete

* Style fix

* minor fixes

* cs

Author: lsv

Command/DeleteObsoleteCommand.php

@@ -54,17 +54,41 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $storage = $container->get('php_translation.storage.'.$configName);
         $messages = $catalogueManager->findMessages(['locale' => $inputLocale, 'isObsolete' => true]);
 
+        $messageCount = count($messages);
+        if (0 === $messageCount) {
+            $output->writeln('No messages are obsolete');
+
+            return;
+        }
+
         $helper = $this->getHelper('question');
-        $question = new ConfirmationQuestion(sprintf('You are about to remove %d translations. Do you wish to continue?', count($messages)), false);
+        $question = new ConfirmationQuestion(sprintf('You are about to remove %d translations. Do you wish to continue? (y/N) ', $messageCount), false);
         if (!$helper->ask($input, $output, $question)) {
             return;
         }
 
-        $progress = new ProgressBar($output, count($messages));
+        $progress = null;
+        if (OutputInterface::VERBOSITY_NORMAL === $output->getVerbosity() && OutputInterface::VERBOSITY_QUIET !== $output->getVerbosity()) {
+            $progress = new ProgressBar($output, $messageCount);
+        }
         foreach ($messages as $message) {
             $storage->delete($message->getLocale(), $message->getDomain(), $message->getKey());
-            $progress->advance();
+            if ($output->getVerbosity() > OutputInterface::VERBOSITY_NORMAL) {
+                $output->writeln(sprintf(
+                    'Deleted obsolete message "<info>%s</info>" from domain "<info>%s</info>" and locale "<info>%s</info>"',
+                    $message->getKey(),
+                    $message->getDomain(),
+                    $message->getLocale()
+                ));
+            }
+
+            if ($progress) {
+                $progress->advance();
+            }
+        }
+
+        if ($progress) {
+            $progress->finish();
         }
-        $progress->finish();
     }
 }

DependencyInjection/TranslationExtension.php

@@ -142,7 +142,7 @@ private function handleConfigNode(ContainerBuilder $container, array $config)
             // Create some aliases for the default storage
             $container->setAlias('php_translation.storage', new Alias('php_translation.storage.'.$first, true));
             if ('default' !== $first) {
-                $container->setAlias('php_translation.storage.default', 'php_translation.storage.'.$first);
+                $container->setAlias('php_translation.storage.default', new Alias('php_translation.storage.'.$first, true));
             }
         }
     }