have_posts() is an impure function (#64)

* `have_posts()` is an impure function.

* Sort these functions.

* Remove the trailing space.

* Address `WP_Query::have_posts()`.

Author: johnbillion

functionMap.php

@@ -13,6 +13,7 @@
 return [
     'add_meta_box' => ['void', 'context'=>'"normal"|"side"|"advanced"', 'priority'=>'"high"|"core"|"default"|"low"'],
     'addslashes_gpc' => ['T', '@phpstan-template'=>'T', 'gpc'=>'T'],
+    'have_posts' => ['bool', '@phpstan-impure'=>''],
     'rawurlencode_deep' => ['T', '@phpstan-template'=>'T', 'value'=>'T'],
     'remove_meta_box' => ['void', 'context'=>'"normal"|"side"|"advanced"'],
     'sanitize_category' => ['T', '@phpstan-template'=>'T of array|object', 'category'=>'T'],
@@ -32,6 +33,7 @@
     'WP_List_Table::display_tablenav' => ['void', 'which'=>'"top"|"bottom"'],
     'WP_List_Table::pagination' => ['void', 'which'=>'"top"|"bottom"'],
     'wp_next_scheduled' => ['int|false', 'args'=>$cronArgsType],
+    'WP_Query::have_posts' => ['bool', '@phpstan-impure'=>''],
     'wp_remote_get' => [$httpReturnType],
     'wp_remote_head' => [$httpReturnType],
     'wp_remote_post' => [$httpReturnType],

visitor.php

@@ -630,8 +630,9 @@ private function getAdditionalTagsFromMap(string $symbolName): array
 
         foreach ($parameters as $paramName => $paramType) {
             if (strpos($paramName, '@') === 0) {
+                $format = ( $paramType === '' ) ? '%s' : '%s %s';
                 $additions[] = sprintf(
-                    '%s %s',
+                    $format,
                     $paramName,
                     $paramType
                 );

wordpress-stubs.php

@@ -45136,6 +45136,8 @@ public function the_post()
          * @since 1.5.0
          *
          * @return bool True if posts are available, false if end of the loop.
+         * @phpstan-impure
+         * @phpstan-return bool
          */
         public function have_posts()
         {
@@ -122372,6 +122374,8 @@ function is_main_query()
      * @global WP_Query $wp_query WordPress Query object.
      *
      * @return bool True if posts are available, false if end of the loop.
+     * @phpstan-impure
+     * @phpstan-return bool
      */
     function have_posts()
     {