Skip to content

Commit d703e7b

Browse files
committed
Fix tests
1 parent fbb04ad commit d703e7b

File tree

4 files changed

+5
-28
lines changed

4 files changed

+5
-28
lines changed

src/Factory/ResultRendererFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,6 @@ public function create(ResultInterface $result): ResultRendererInterface
8080
*/
8181
protected function isImplementationNameOfClass(string $implementationName, string $className): bool
8282
{
83-
return is_string($implementationName) && is_subclass_of($implementationName, $className);
83+
return is_subclass_of($implementationName, $className);
8484
}
8585
}

src/Result/Cgi/CgiResult.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use ArrayIterator;
66
use IteratorAggregate;
7-
use PhpSchool\PhpWorkshop\Result\Cli\ResultInterface;
7+
use PhpSchool\PhpWorkshop\Result\Cgi\ResultInterface;
88
use PhpSchool\PhpWorkshop\Result\ResultGroupInterface;
99

1010
/**

src/UserState.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
*/
99
class UserState
1010
{
11-
1211
/**
13-
* @var string
12+
* @var string|null
1413
*/
1514
private $currentExercise;
1615

@@ -57,9 +56,9 @@ public function setCurrentExercise(string $exercise): void
5756
/**
5857
* Get the current exercise name.
5958
*
60-
* @return string
59+
* @return string|null
6160
*/
62-
public function getCurrentExercise(): string
61+
public function getCurrentExercise(): ?string
6362
{
6463
return $this->currentExercise;
6564
}

test/Factory/ResultRendererFactoryTest.php

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,28 +33,6 @@ public function testRegisterRendererRequiresResultRendererInterface(): void
3333
$factory->registerRenderer($resultClass, $rendererClass);
3434
}
3535

36-
public function testRegisterRendererRequiresResultClassToBeString(): void
37-
{
38-
$this->expectException(InvalidArgumentException::class);
39-
40-
$resultClass = $this->createMock(ResultInterface::class);
41-
$rendererClass = get_class($this->createMock(ResultRendererInterface::class));
42-
$factory = new ResultRendererFactory();
43-
44-
$factory->registerRenderer($resultClass, $rendererClass);
45-
}
46-
47-
public function testRegisterRendererRequiresRendererClassToBeString(): void
48-
{
49-
$this->expectException(InvalidArgumentException::class);
50-
51-
$resultClass = get_class($this->createMock(ResultInterface::class));
52-
$rendererClass = $this->createMock(ResultRendererInterface::class);
53-
$factory = new ResultRendererFactory();
54-
55-
$factory->registerRenderer($resultClass, $rendererClass);
56-
}
57-
5836
public function testCreateRequiresMappingToClassName(): void
5937
{
6038
$this->expectException(RuntimeException::class);

0 commit comments

Comments
 (0)