add typehint to every properties

Author: guillaume-sainthillier

src/bref/bref/Context.php

@@ -11,24 +11,14 @@
  */
 final class Context implements \JsonSerializable
 {
-    /** @var string */
-    private $awsRequestId;
-
-    /** @var int Holds the deadline Unix timestamp in millis */
-    private $deadlineMs;
-
-    /** @var string */
-    private $invokedFunctionArn;
-
-    /** @var string */
-    private $traceId;
-
-    public function __construct(string $awsRequestId, int $deadlineMs, string $invokedFunctionArn, string $traceId)
+    public function __construct(
+        private string $awsRequestId,
+        /** @var int Holds the deadline Unix timestamp in millis */
+        private int $deadlineMs,
+        private string $invokedFunctionArn,
+        private string $traceId
+    )
     {
-        $this->awsRequestId = $awsRequestId;
-        $this->deadlineMs = $deadlineMs;
-        $this->invokedFunctionArn = $invokedFunctionArn;
-        $this->traceId = $traceId;
     }
 
     /**

src/bref/src/BrefRunner.php

@@ -13,13 +13,8 @@
  */
 class BrefRunner implements RunnerInterface
 {
-    private $handler;
-    private $loopMax;
-
-    public function __construct(Handler $handler, int $loopMax)
+    public function __construct(private Handler $handler, private int $loopMax)
     {
-        $this->handler = $handler;
-        $this->loopMax = $loopMax;
     }
 
     public function run(): int

src/bref/src/ConsoleApplicationHandler.php

@@ -15,7 +15,7 @@
  */
 class ConsoleApplicationHandler implements Handler
 {
-    private $application;
+    private Application $application;
 
     public function __construct(Application $application)
     {

src/bref/src/ConsoleApplicationRunner.php

@@ -13,13 +13,11 @@
  */
 class ConsoleApplicationRunner implements RunnerInterface
 {
-    private $handler;
-    private $loopMax;
+    private ConsoleApplicationHandler $handler;
 
-    public function __construct(Application $application, int $loopMax = 1)
+    public function __construct(Application $application, private int $loopMax = 1)
     {
         $this->handler = new ConsoleApplicationHandler($application);
-        $this->loopMax = $loopMax;
     }
 
     public function run(): int

src/bref/src/Lambda/ContextBuilder.php

@@ -10,16 +10,16 @@
 final class ContextBuilder
 {
     /** @var string */
-    private $awsRequestId;
+    private string $awsRequestId;
 
     /** @var int */
-    private $deadlineMs;
+    private int $deadlineMs;
 
     /** @var string */
-    private $invokedFunctionArn;
+    private string $invokedFunctionArn;
 
     /** @var string */
-    private $traceId;
+    private string $traceId;
 
     public function __construct()
     {

src/bref/src/Lambda/LambdaClient.php

@@ -38,24 +38,20 @@ final class LambdaClient
     private $returnHandler;
 
     /** @var string */
-    private $apiUrl;
-
-    /** @var string */
-    private $layer;
+    private string $apiUrl;
 
     public static function fromEnvironmentVariable(string $layer): self
     {
         return new self((string) getenv('AWS_LAMBDA_RUNTIME_API'), $layer);
     }
 
-    public function __construct(string $apiUrl, string $layer)
+    public function __construct(string $apiUrl, private string $layer)
     {
         if ('' === $apiUrl) {
             exit('At the moment lambdas can only be executed in an Lambda environment');
         }
 
         $this->apiUrl = $apiUrl;
-        $this->layer = $layer;
     }
 
     public function __destruct()

src/bref/src/LaravelHttpHandler.php

@@ -16,7 +16,7 @@
  */
 class LaravelHttpHandler extends HttpHandler
 {
-    private $kernel;
+    private Kernel $kernel;
 
     public function __construct(Kernel $kernel)
     {

src/bref/src/LocalRunner.php

@@ -13,13 +13,8 @@
  */
 class LocalRunner implements RunnerInterface
 {
-    private $handler;
-    private $data;
-
-    public function __construct(Handler $handler, $data)
+    public function __construct(private Handler $handler, private mixed $data)
     {
-        $this->handler = $handler;
-        $this->data = $data;
     }
 
     public function run(): int

src/bref/src/SymfonyHttpHandler.php

@@ -17,12 +17,8 @@
  */
 class SymfonyHttpHandler extends HttpHandler
 {
-    private $kernel;
-
-    public function __construct(HttpKernelInterface $kernel)
+    public function __construct(private HttpKernelInterface $kernel)
     {
-        $this->kernel = $kernel;
-
         Request::setTrustedProxies(['127.0.0.1'], Request::HEADER_X_FORWARDED_FOR | Request::HEADER_X_FORWARDED_HOST | Request::HEADER_X_FORWARDED_PORT | Request::HEADER_X_FORWARDED_PROTO);
     }
 

src/bref/tests/Lambda/LambdaClientTest.php

@@ -17,7 +17,7 @@
 class LambdaClientTest extends TestCase
 {
     /** @var LambdaClient */
-    private $lambda;
+    private LambdaClient $lambda;
 
     protected function setUp(): void
     {