Skip to content

Commit b2aeee3

Browse files
authored
Merge pull request #481 from ip512/fix-web-profiler-bundle-routing-conf-in-tests
fix: update routing configuration to use PHP files for WebProfilerBundle
2 parents 23dcb4f + 420d3ec commit b2aeee3

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ jobs:
6565
symfony-require: "6.4.*"
6666
php-version: "8.2"
6767
symfony-deprecations-helper: "weak"
68-
- dependencies: "php-http/guzzle7-adapter symfony/http-client:^7.1"
69-
symfony-require: "7.1.*"
68+
- dependencies: "php-http/guzzle7-adapter symfony/http-client:^7.3"
69+
symfony-require: "7.3.*"
7070
php-version: "8.2"
7171
symfony-deprecations-helper: "weak"
7272

tests/Resources/app/AppKernel.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,10 @@ public function loadRoutes(LoaderInterface $loader): RouteCollection
6666
$collection->add('/', new Route('/', ['_controller' => 'kernel::indexAction']));
6767

6868
$routes = new RoutingConfigurator($collection, $kernelLoader, $file, $file);
69-
$routes->import('@WebProfilerBundle/Resources/config/routing/wdt.xml')->prefix('_wdt');
70-
$routes->import('@WebProfilerBundle/Resources/config/routing/profiler.xml')->prefix('_profiler');
69+
// TODO hardcode xml when we support only Symfony 7.3 or higher.
70+
$extension = self::MAJOR_VERSION >= 7 ? 'php' : 'xml';
71+
$routes->import('@WebProfilerBundle/Resources/config/routing/wdt.'.$extension)->prefix('_wdt');
72+
$routes->import('@WebProfilerBundle/Resources/config/routing/profiler.'.$extension)->prefix('_profiler');
7173

7274
return $collection;
7375
}

0 commit comments

Comments
 (0)