Merge pull request #4 from php-enspired/unconstructable

Fix Constructor Process

Author: adrian-enspired

src/Exception.php

@@ -93,16 +93,22 @@ public static function has_info(int $code) : bool {
   /** @see Exceptable::__construct() */
   public function __construct(...$arguments) {
     $args = $arguments;
+
     $message = is_string(reset($args)) ? array_shift($args) : null;
-    $code = is_int(reset($args)) ? array_shift($args) : null;
+    $code = $this->_makeCode(is_int(reset($args)) ? array_shift($args) : null);
     $previous = (reset($args) instanceof Throwable) ? array_shift($args) : null;
-    if (is_array(reset($args))) {
-      $this->addContext(array_shift($args));
+    $this->setSeverity($this->_makeSeverity($code));
+
+    $context = is_array(reset($args)) ? array_shift($args) : [];
+    $context['__severity__'] = $this->getSeverity();
+    if ($previous) {
+      $context['__rootMessage__'] = $this->_getRoot($previous)->getMessage();
     }
-    $code = $this->_makeCode($code);
+    $this->addContext($context);
+
     $message = $this->_makeMessage($message, $code);
-    $this->setSeverity($this->_makeSeverity($code));
-    $this->addContext(['__severity__' => $this->getSeverity()]);
+
+    parent::__construct($message, $code, $previous);
 
     // exceptional exceptable: bad args
     if (! empty($args)) {
@@ -111,11 +117,6 @@ public function __construct(...$arguments) {
         ['args' => $arguments]
       );
     }
-
-    parent::__construct($message, $code, $previous);
-    if ($previous) {
-      $this->addContext(['__rootMessage__' => $this->getRoot()->getMessage()]);
-    }
   }
 
   /** @see <http://php.net/__toString> */
@@ -141,11 +142,7 @@ public function getContext() : array {
 
   /** @see Exceptable::getRoot() */
   public function getRoot() : Throwable {
-    $root = $this;
-    while ($root->getPrevious() !== null) {
-      $root = $root->getPrevious();
-    }
-    return $root;
+    return $this->_getRoot($this);
   }
 
   /** @see Exceptable::getSeverity() */
@@ -182,6 +179,20 @@ public function setSeverity(int $severity) : Exceptable {
     return $this;
   }
 
+  /**
+   * Finds the root exception.
+   *
+   * @param Throwable $leaf The exception to start from
+   * @return Throwable The root exception
+   */
+  public function _getRoot(Throwable $leaf) : Throwable {
+    $root = $leaf;
+    while ($root->getPrevious() !== null) {
+      $root = $root->getPrevious();
+    }
+    return $root;
+  }
+
   /**
    * generates a default exception code.
    *