You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During phetsims/number-pairs#217, I made a change to one a11y string in a yaml file, and when I went to commit the changes from modulify, there were changes in 5 files across 2 repos:
This is very noisy and suffers from the antipattern of committing "build" artifacts.
I'm aware of 3 steps that would be required to deal with this:
Eliminate all static servers. I'm aware that phet test, soon to be launchpad, uses a static server. It would need to convert to grunt dev-server. Not sure if there are others.
We may also want to add caching for this step in the build server, if it speeds things up.
This would also eliminate the modulify step from development, or when designers change yaml files.
However, we still need to generate the *Fluent.ts file when changing yaml keys or variables, since the type information changes, and the type checker relies on static files (that would be crazy if the type checker loaded a "redirect" generated file from localhost/).
I see enough caveats or costs here that this may not be an easy step. May be good to consider with the development team, especially if we have requirements that static servers must work somewhere.
During phetsims/number-pairs#217, I made a change to one a11y string in a yaml file, and when I went to commit the changes from modulify, there were changes in 5 files across 2 repos:
This is very noisy and suffers from the antipattern of committing "build" artifacts.
I'm aware of 3 steps that would be required to deal with this:
grunt dev-server. Not sure if there are others.We may also want to add caching for this step in the build server, if it speeds things up.
This would also eliminate the modulify step from development, or when designers change yaml files.
However, we still need to generate the *Fluent.ts file when changing yaml keys or variables, since the type information changes, and the type checker relies on static files (that would be crazy if the type checker loaded a "redirect" generated file from localhost/).
I see enough caveats or costs here that this may not be an easy step. May be good to consider with the development team, especially if we have requirements that static servers must work somewhere.
Overlaps somewhat with #1595 (comment)