clang-tidy: check and fix cppcoreguidelines-pro-type-union-access

Author: Abdelrhmansersawy

.clang-tidy

@@ -20,7 +20,6 @@ Checks: >
     -cppcoreguidelines-pro-type-const-cast,
     -cppcoreguidelines-pro-type-member-init,
     -cppcoreguidelines-pro-type-reinterpret-cast,
-    -cppcoreguidelines-pro-type-union-access,
     -cppcoreguidelines-pro-type-vararg,
     -cppcoreguidelines-slicing
 

include/c_common/enums.h

@@ -25,7 +25,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #ifndef INCLUDE_C_COMMON_ENUMS_H_
 #define INCLUDE_C_COMMON_ENUMS_H_
 
-enum Which {
+enum Which {  // NOLINT(cppcoreguidelines-use-enum-class)
     /** undirected graph + results: vertex id  */
     SLOAN = 0, CUTCHILL, KING,
     /** directed graph + results: vertex id  */

include/c_types/ii_t_rt.h

@@ -40,8 +40,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #endif
 
 struct II_t_rt {
-    union {int64_t id; int64_t source; int64_t start_vid;} d1;
-    union {int64_t value; int64_t target; int64_t end_vid;} d2;
+    int64_t d1;
+    int64_t d2;
 };
 
 

include/coloring/bipartite_driver.hpp

@@ -80,7 +80,7 @@ class Pgr_Bipartite : public pgrouting::Pgr_messages {
                     int64_t vid = graph[*v].id;
                     boost::get(partition_map, *v) ==
                         boost::color_traits <boost::default_color_type>::white() ?
-                        results.push_back({{vid}, {0}}) : results.push_back({{vid}, {1}});
+                        results.push_back({vid, 0}) : results.push_back({vid, 1});
                 }
                 return results;
             }

include/coloring/sequentialVertexColoring.hpp

@@ -127,13 +127,13 @@ class Pgr_sequentialVertexColoring {
          for (boost::tie(v, vend) = vertices(graph.graph); v != vend; ++v) {
              int64_t node = graph[*v].id;
              auto color = colors[*v];
-             results.push_back({{node}, {static_cast<int64_t>(color + 1)}});
+             results.push_back({node, static_cast<int64_t>(color + 1)});
          }
 
          // ordering the results in an increasing order of the node id
          std::sort(results.begin(), results.end(),
              [](const II_t_rt row1, const II_t_rt row2) {
-                 return row1.d1.id < row2.d1.id;
+                 return row1.d1 < row2.d1;
              });
 
          return results;

include/components/makeConnected.hpp

@@ -92,7 +92,7 @@ class Pgr_makeConnected : public pgrouting::Pgr_messages {
               int64_t tgt = graph[graph.target(*ei)].id;
               log<< "src:" << src<< "tgt:" << tgt <<"\n";
               if (newEdge >= edgeCount) {
-                   results[i] = {{src}, {tgt}};
+                   results[i] = {src, tgt};
                    i++;
               }
               newEdge++;

include/cpp_common/info_t.hpp

@@ -35,7 +35,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 namespace pgrouting {
 
-enum expectType {
+enum class expectType {
     ANY_INTEGER,
     ANY_NUMERICAL,
     TEXT,

include/trsp/trspHandler.hpp

@@ -67,7 +67,7 @@ class TrspHandler : public pgrouting::Pgr_messages {
      *
      * The "legal" values are indices to vectors
      */
-    enum Position {ILLEGAL = -1, RC_EDGE = 0, C_EDGE = 1};
+    enum Position {ILLEGAL = -1, RC_EDGE = 0, C_EDGE = 1};  // NOLINT(cppcoreguidelines-use-enum-class)
 
 
     class Predecessor {

include/vrp/initials_code.hpp

@@ -32,7 +32,7 @@ namespace pgrouting {
 namespace vrp {
 
 /*! Different kinds to insert an order into the vehicle */
-enum Initials_code {
+enum Initials_code {  // NOLINT(cppcoreguidelines-use-enum-class)
     OneTruck,    /*! All orders in one truck */
     OnePerTruck, /*! One Order per truck */
     FrontTruck,  /*! Insertion, at the front of the truck */

include/vrp/tw_node.hpp

@@ -56,7 +56,7 @@ namespace vrp {
  */
 class Tw_node : public Dnode {
  public:
-     typedef enum {
+     typedef enum {  // NOLINT(cppcoreguidelines-use-enum-class)
          kStart = 0,  ///< starting site
          kPickup,  ///< pickup site
          kDelivery,  ///< delivery site