test: remove flaky sync tests

The sync components need to be rewritten in a way that is easily tested. For now these are causing semi regular test failures that are not actionable.

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsRESTAPISettingsSyncTestCase.inc

@@ -65,41 +65,4 @@ class APIModelsRESTAPISettingsSyncTestCase extends TestCase {
         $this->assert_equals($original_api_config, $new_api_config);
         $this->assert_not_equals($sync_api_config, $new_api_config);
     }
-
-    /**
-     * Checks that the 'sync()' method correctly syncs the API config to HA peers.
-     */
-    public function test_sync(): void {
-        # Use a non-pfSense host as an HA peer
-        $api_settings = new RESTAPISettings();
-        $api_settings->ha_sync->value = true;
-        $api_settings->ha_sync_hosts->value = ['www.example.com'];
-        $api_settings->ha_sync_username->value = 'admin';
-        $api_settings->ha_sync_password->value = 'pfsense';
-        $api_settings->update();
-
-        # Read the syslog and ensure the synced failed
-        # TODO: This test is flaky and needs to be reworked
-        //        RESTAPISettingsSync::sync();
-        //        $syslog = file_get_contents('/var/log/system.log');
-        //        $this->assert_str_contains(
-        //            $syslog,
-        //            'Failed to sync REST API settings to example.com: received unexpected response.',
-        //        );
-
-        # Use a non-existent host as an HA peer and ensure the sync failed
-        $api_settings->ha_sync_hosts->value = ['127.1.2.3'];
-        $api_settings->update();
-        RESTAPISettingsSync::sync();
-        $syslog = file_get_contents('/var/log/system.log');
-        $this->assert_str_contains($syslog, 'Failed to sync REST API settings to 127.1.2.3: no response received.');
-
-        # Use bad credentials and ensure the sync failed
-        $api_settings->ha_sync_hosts->value = ['127.0.0.1'];
-        $api_settings->ha_sync_password->value = 'bad password';
-        $api_settings->update();
-        RESTAPISettingsSync::sync();
-        $syslog = file_get_contents('/var/log/system.log');
-        $this->assert_str_contains($syslog, 'Failed to sync REST API settings to 127.0.0.1: Authentication failed');
-    }
 }