refactor into luhn function

Author: Peter Mueller

lib/ex_junk.ex

@@ -42,23 +42,8 @@ defmodule Junk do
     base_digits = junk(Integer, opts)
     |> Integer.digits
     |> (fn digits -> [8,0,8,4,0] ++ [Enum.random(1..2)] ++ digits end).()
-
-    # starting from the right, doubles digits
-    # splits into 2 digits where needed
-    # sums, and adds 24 (for the 80840 of the longer form npi)
-    check_sum = base_digits
-    |> Enum.reverse
-    |> Junk.map_every(2, fn(n) ->Integer.digits(n*2) end)
-    |> List.flatten
-    |> Enum.sum
-
-    # calcs the check digit
-    check_digit = case Kernel.rem(check_sum, 10) do
-      0 -> 0
-      n -> 10 - n
-    end
-
-    (base_digits ++ [check_digit]) |> Integer.undigits
+    |> Integer.undigits
+    |> Junk.luhn
   end
 
   def junk(:npi, opts) do
@@ -79,6 +64,23 @@ defmodule Junk do
     end
   end
 
+  def luhn(number) do
+    base_digits = Integer.digits(number)
+    check_sum = base_digits
+    |> Enum.reverse
+    |> Junk.map_every(2, fn(n) ->Integer.digits(n*2) end)
+    |> List.flatten
+    |> Enum.sum
+
+    # calcs the check digit
+    check_digit = case Kernel.rem(check_sum, 10) do
+      0 -> 0
+      n -> 10 - n
+    end
+
+    (base_digits ++ [check_digit]) |> Integer.undigits
+  end
+
   def map_every(enumerable, nth, mapper) do
     {res, _acc} = Enum.map_reduce(enumerable, 0, fn(x, i) -> if (rem(i, nth) == 0) do
         {mapper.(x), i+1}

test/ex_junk_test.exs

@@ -99,6 +99,10 @@ defmodule JunkTest do
     assert Enum.member?([808401,808402], first_6)
   end
 
+  test "luhn returns a luhn'd number" do
+    assert Junk.luhn(80840268496713) == 808402684967138
+  end
+
   def ssn do
     "123-45-6789"
   end