Skip to content

Commit c91a125

Browse files
authored
Fixes missing visible attribute in spawn_ground_plane (isaac-sim#3304)
# Description `GroundPlaneCfg` allows for specifying `visible` parameter, but this would not being parsed in `spawn_ground_plane`, resulting in the parameter being a no-op when specified. This change adds a fix to parse the `visible` parameter from the cfg and sets the visibility attribute for the ground plane cfg appropriately. Fixes isaac-sim#3263 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent 0f00ca2 commit c91a125

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

source/isaaclab/isaaclab/sim/spawners/from_files/from_files.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,10 @@ def spawn_ground_plane(
217217
# create semantic type and data attributes
218218
sem.CreateSemanticTypeAttr().Set(semantic_type)
219219
sem.CreateSemanticDataAttr().Set(semantic_value)
220+
221+
# Apply visibility
222+
prim_utils.set_prim_visibility(prim, cfg.visible)
223+
220224
# return the prim
221225
return prim
222226

0 commit comments

Comments
 (0)