From 0d2b973ffdc8dacb1fa1a16daffa4b58516f54c6 Mon Sep 17 00:00:00 2001
From: leaves <13081541293@163.com>
Date: Tue, 21 Apr 2026 23:21:02 +0800
Subject: [PATCH 1/2] Improve error message for array comparison in Should -Be

Show collection length and type when array comparison fails due to
different lengths or types, addressing confusing error messages
where both sides appeared identical.

Related: #1154
---
 src/functions/assertions/Be.ps1 | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/src/functions/assertions/Be.ps1 b/src/functions/assertions/Be.ps1
index 8e1356e08..6411a78ad 100644
--- a/src/functions/assertions/Be.ps1
+++ b/src/functions/assertions/Be.ps1
@@ -47,23 +47,30 @@ function Should-BeAssertion ($ActualValue, $ExpectedValue, [switch] $Negate, [st
 }
 
 function ShouldBeFailureMessage($ActualValue, $ExpectedValue, $Because) {
-    # This looks odd; it's to unroll single-element arrays so the "-is [string]" expression works properly.
-    $ActualValue = $($ActualValue)
-    $ExpectedValue = $($ExpectedValue)
 
-    if (-not (($ExpectedValue -is [string]) -and ($ActualValue -is [string]))) {
-        return "Expected $(Format-Nicely $ExpectedValue),$(if ($null -ne $Because) { Format-Because $Because }) but got $(Format-Nicely $ActualValue)."
+    $actualType = if ($null -eq $ActualValue) { '<null>' } else { $ActualValue.GetType().Name }
+    $expectedType = if ($null -eq $ExpectedValue) { '<null>' } else { $ExpectedValue.GetType().Name }
+    
+    $actualCount = if ($ActualValue -is [Array]) { $ActualValue.Count } else { 1 }
+    $expectedCount = if ($ExpectedValue -is [Array]) { $ExpectedValue.Count } else { 1 }
+
+
+    $ActualValueUnrolled = $($ActualValue)
+    $ExpectedValueUnrolled = $($ExpectedValue)
+
+
+    if ($actualType -ne $expectedType -or ($ActualValue -is [Array] -and $ExpectedValue -is [Array] -and $actualCount -ne $expectedCount)) {
+        $message = "Expected a collection with length $expectedCount and type [$expectedType], but got a collection with length $actualCount and type [$actualType].`n"
+        $message += "Expected: $(Format-Nicely $ExpectedValue)`n"
+        $message += "Actual:   $(Format-Nicely $ActualValue)"
+        if ($Because) { $message += "`nBecause: $Because" }
+        return $message
     }
-    <#joining the output strings to a single string here, otherwise I get
-       Cannot find an overload for "Exception" and the argument count: "4".
-       at line: 63 in C:\Users\nohwnd\github\pester\functions\Assertions\Should.ps1
 
-    This is a quickwin solution, doing the join in the Should directly might be better
-    way of doing this. But I don't want to mix two problems.
-    #>
-    (Get-CompareStringMessage -Expected $ExpectedValue -Actual $ActualValue -Because $Because) -join "`n"
+
 }
 
+
 function NotShouldBeFailureMessage($ActualValue, $ExpectedValue, $Because) {
     return "Expected $(Format-Nicely $ExpectedValue) to be different from the actual value,$(if ($null -ne $Because) { Format-Because $Because }) but got the same value."
 }

From 6e07b7915775b6b4058a80f4d4ce44feba5587b5 Mon Sep 17 00:00:00 2001
From: leaves <13081541293@163.com>
Date: Wed, 22 Apr 2026 16:55:42 +0800
Subject: [PATCH 2/2] Update Be.ps1

---
 src/functions/assertions/Be.ps1 | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/functions/assertions/Be.ps1 b/src/functions/assertions/Be.ps1
index 6411a78ad..dccfccab3 100644
--- a/src/functions/assertions/Be.ps1
+++ b/src/functions/assertions/Be.ps1
@@ -45,21 +45,19 @@ function Should-BeAssertion ($ActualValue, $ExpectedValue, [switch] $Negate, [st
         }
     }
 }
-
 function ShouldBeFailureMessage($ActualValue, $ExpectedValue, $Because) {
-
+    # 获取类型和长度信息
     $actualType = if ($null -eq $ActualValue) { '<null>' } else { $ActualValue.GetType().Name }
     $expectedType = if ($null -eq $ExpectedValue) { '<null>' } else { $ExpectedValue.GetType().Name }
-    
+
     $actualCount = if ($ActualValue -is [Array]) { $ActualValue.Count } else { 1 }
     $expectedCount = if ($ExpectedValue -is [Array]) { $ExpectedValue.Count } else { 1 }
 
+    # 判断是否需要显示类型/长度详情
+    $showDetail = ($actualType -ne $expectedType) -or 
+                  ($ActualValue -is [Array] -and $ExpectedValue -is [Array] -and $actualCount -ne $expectedCount)
 
-    $ActualValueUnrolled = $($ActualValue)
-    $ExpectedValueUnrolled = $($ExpectedValue)
-
-
-    if ($actualType -ne $expectedType -or ($ActualValue -is [Array] -and $ExpectedValue -is [Array] -and $actualCount -ne $expectedCount)) {
+    if ($showDetail) {
         $message = "Expected a collection with length $expectedCount and type [$expectedType], but got a collection with length $actualCount and type [$actualType].`n"
         $message += "Expected: $(Format-Nicely $ExpectedValue)`n"
         $message += "Actual:   $(Format-Nicely $ActualValue)"
@@ -67,7 +65,16 @@ function ShouldBeFailureMessage($ActualValue, $ExpectedValue, $Because) {
         return $message
     }
 
+    # 原有逻辑：处理普通情况和字符串
+    $ActualValueUnrolled = $($ActualValue)
+    $ExpectedValueUnrolled = $($ExpectedValue)
+
+    if (-not (($ExpectedValueUnrolled -is [string]) -and ($ActualValueUnrolled -is [string]))) {
+        return "Expected $(Format-Nicely $ExpectedValue),$(if ($null -ne $Because) { " because $Because" } else { '' }) but got $(Format-Nicely $ActualValue)."
+    }
 
+    # 字符串比较的特殊处理
+    (Get-CompareStringMessage -Expected $ExpectedValueUnrolled -Actual $ActualValueUnrolled -Because $Because)
 }