"Optimize file status retrieval" setting resets to "Do not optimize" after closing dialog if set to "Optimize file state retrieval"

[sswires]

Hi,

There is an incredibly annoying issue that has plagued P4VS for a while. If whatever reason you change your file status retrieval setting under VS Settings -> Source Control -> Helix Core - Data Retrieval to "Lazy load file state", press OK, reopen it, set to "Optimize file state retrieval", press OK. Any time you re-open it, including between restarts, it'll set the setting to "Do not optimize" and VS behaves accordingly, which is catastrophic when you are connected to a VPN or otherwise not local to the P4 server.

This should instead correctly use the selected option.

Thanks