From 659c2cf0c24a3a6523b033c7fab38c8805bc0d84 Mon Sep 17 00:00:00 2001 From: Pedro Fuentes Date: Sun, 17 May 2026 17:13:18 -0700 Subject: [PATCH] chore: sync agents-template v0.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Phase 1: exempt PRs (except refactor) skip check 6 (coverage) - Selective dispatch: chore/build/ci → A,E,F only - Dimension F: cross-reference rule for companion docs - Mode declaration: fix hardcoded '6 sub-agents' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- AGENTS.md | 2 +- docs/SENTINEL.md | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 04ab30f..417d1d6 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,5 +1,5 @@ # AGENTS.md — Gitnotate - + > **You are a disciplined software engineer who writes tests before code, works in > isolated branches, and never merges without review.** These are not suggestions — diff --git a/docs/SENTINEL.md b/docs/SENTINEL.md index 8a7beb8..6474be2 100644 --- a/docs/SENTINEL.md +++ b/docs/SENTINEL.md @@ -50,6 +50,8 @@ If you cannot identify the exact SHA being reviewed → **REJECT**. ### Phase 1 — TDD compliance (BLOCKING) Verify each 🔴 item using diff + commit history + test/coverage output. If you cannot verify an item → treat as failure. +**Exemptions:** PRs containing ONLY `docs`, `chore`, `build`, `ci`, `refactor` (behavior-preserving), or `style` commits are exempt from checks 1–4; all except `refactor` also skip check 6 (no source code changed). Check 5 still applies — the existing suite must remain green. + | Check | How to verify | Blocks? | |---|---|---| | Tests exist for new/changed behavior | Each new/changed behavior has new/updated tests that execute the change and assert outcomes | 🔴 | @@ -79,9 +81,9 @@ A sub-agent is a **separately-invoked tool call** (e.g., `task`, `dispatch`) exe **Execution logging (REQUIRED):** Record each sub-agent's assigned dimension, status, the exact tool call used to spawn it (e.g., `task(agent_type="general-purpose", name="dim-a")`), and the **tool-returned identifier** when the platform provides one. If the platform technically cannot provide an identifier, log `N/A` with the platform limitation. Missing identifiers when available or fabricated dispatch evidence → REJECT. -**Mode declaration (REQUIRED):** Declare exactly one: `standard` (6 parallel sub-agents), `degraded (serialized)` (6 sequential — protocol violation unless justified), or `degraded (no sub-agents)` (self-reviewed). "Unavailable" = platform **technically lacks** sub-agent capability (tool not present, API error after attempt). Cost, latency, or diff size are NOT valid reasons. Degraded modes require explicit user approval before merge. Omitting Mode is a violation. +**Mode declaration (REQUIRED):** Declare exactly one: `standard` (all applicable dimensions dispatched in parallel), `degraded (serialized)` (applicable dimensions sequential — protocol violation unless justified), or `degraded (no sub-agents)` (self-reviewed). "Unavailable" = platform **technically lacks** sub-agent capability (tool not present, API error after attempt). Cost, latency, or diff size are NOT valid reasons. Degraded modes require explicit user approval before merge. Omitting Mode is a violation. -**Selective dispatch:** PRs with ONLY `docs` or `style` commits (per Phase 1 §Exemptions) → dispatch applicable dimensions (`docs`→F; `style`→D,F), log others as `N/A (exempt)`. All other types → full A–F. If a dispatched sub-agent identifies cross-cutting risk outside its dimensions, escalate to full A–F. +**Selective dispatch:** Fully-exempt PRs (per Phase 1 §Exemptions) → dispatch applicable dimensions only, log others as `N/A (exempt)`: `docs`→F; `style`→D,F; `chore`/`build`/`ci`→A,E,F; `refactor`→A–F. If a dispatched sub-agent identifies cross-cutting risk, escalate to full A–F. #### A) Security, privacy, and correctness (🔴 if violated) - Injection: SQL/NoSQL, XSS, command injection, path traversal, SSRF, deserialization @@ -119,8 +121,7 @@ A sub-agent is a **separately-invoked tool call** (e.g., `task`, `dispatch`) exe - README, CHANGELOG, API docs reflect current behavior (not stale) - New features/changes documented; deprecated features noted - Code comments explain WHY, not WHAT (no misleading or outdated comments) -- DECISIONS.md updated if architectural choices were made -- LEARNINGS.md updated if gotchas were discovered +- DECISIONS.md / LEARNINGS.md updated when applicable (content already in another companion doc satisfies if cited by path/section — duplication not required, 🟢 max) ### Phase 3 — Classify findings Aggregate findings from all Phase 2 sub-agents, then classify using exactly these priority levels: