Encrypt notes asynchronously

[ipariparipa]

The new encryption method is pretty slow, takes too many time when auto saving. It is a really wrong user experience at typing. You should move the encryption algorithm into a thread.

[pbek]

I tested a 1000 lines note and did not have any delay when saving while typing.

Can I get a little more context please? What are you comparing it to? What note did you use? How about the logs and settings dump (see issue template)?

[pbek]

26.5.13

• Improved autosaving encrypted notes by running the expensive Botan encryption
  step in a worker thread, keeping typing responsive while encrypted notes are
  saved and avoiding overwriting newer edits made during encryption
  (for #3617)

[pbek]

There now is a new release, could you please test it and report if it works for you?

[ipariparipa]

hmm… something is not really correct. Now this is extremely slow when typing into the a big enrypted text. It seems it's caused by your previous commit (62b72f1e3da08703e40c0c100ac851c8d8c02fc9, maybe somewhere around of method: NoteEncryptionManager::updateNoteEncryptionUI?) Note: this is maybe not reproducible when debugging with gdb, but I'm not pretty sure.

a file for testing (pwd: fakutya):
Háború és béke.md

Info: "DEFINES=QTKEYCHAIN_NO_EXPORT" is needed for building from main (85b46fb64e62d8bfa21d869a91b0b096127227c1) on linux with submodules.

[ipariparipa]

more info: it seems the issue described above is no longer reproducible when regenerating the config file ~/.config/PBE/QOwnNotes.conf (and it explains the different behavior in debug ☺). I'm still testing…

more info # 2: the issue was also not reproducible when I moved the big file into a subdir of Notes, or into a different Notes dir.