Merge pull request #93 from payplug/PRE-2814-fix-double-auth

PRE-2814 refactor: Fix double auth

Author: hdelaforce-payplug

lib/Payplug/Authentication.php

@@ -298,7 +298,6 @@ public static function getRegisterUrl($setup_redirection_uri = '', $oauth_callba
         if (empty($oauth_callback_uri)) {
             throw new Exception\ConfigurationException('Expected string values for oauth callback uri.');
         }
-        $httpClient = new Core\HttpClient(null);
 
         $url_datas = array(
             'setup_redirection_uri' => $setup_redirection_uri,
@@ -307,11 +306,7 @@ public static function getRegisterUrl($setup_redirection_uri = '', $oauth_callba
 
         $route = Core\APIRoutes::getServiceRoute(Core\APIRoutes::PLUGIN_SETUP_SERVICE, $url_datas);
 
-        return $httpClient->get(
-            $route,
-            null,
-            false
-        );
+        return $route;
     }
 
     /**

tests/unit_tests/AuthenticationTest.php

@@ -393,27 +393,12 @@ public function testGetRegisterUrl()
     {
         $setup_redirection_uri = 'setup.redirection.uri.com';
         $oauth_callback_uri = 'oauth.callback.uri.com';
-        $response = array(
-            'redirect_to' => 'portal.uri.com'
+        $register_url = Authentication::getRegisterUrl($setup_redirection_uri, $oauth_callback_uri);
+        $parameters = array(
+            'setup_redirection_uri' => $setup_redirection_uri,
+            'oauth_callback_uri' => $oauth_callback_uri,
         );
-        $this->_requestMock
-            ->expects($this->once())
-            ->method('exec')
-            ->will($this->returnValue(json_encode($response)));
-
-        $this->_requestMock
-            ->expects($this->any())
-            ->method('getinfo')
-            ->will($this->returnCallback(function ($option) {
-                switch ($option) {
-                    case CURLINFO_HTTP_CODE:
-                        return 200;
-                }
-                return null;
-            }));
-
-        $authentication = Authentication::getRegisterUrl($setup_redirection_uri, $oauth_callback_uri);
-        $this->assertEquals(200, $authentication['httpStatus']);
-        $this->assertEquals($response, $authentication['httpResponse']);
+        $expect = Core\APIRoutes::$SERVICE_BASE_URL . Core\APIRoutes::PLUGIN_SETUP_SERVICE . '?' . http_build_query($parameters);
+        $this->assertEquals($expect, $register_url);
     }
 }