Skip to content

Commit e9edb1f

Browse files
committed
refactor: remove util.utf8 usage and update deprecation warning for Python version support
1 parent 2aa7409 commit e9edb1f

File tree

5 files changed

+6
-24
lines changed

5 files changed

+6
-24
lines changed

payjp/api_requestor.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from . import (
1515
error,
1616
http_client,
17-
util,
1817
version,
1918
)
2019

@@ -185,14 +184,13 @@ def _encode_datetime(dttime):
185184

186185
def _api_encode(data):
187186
for key, value in data.items():
188-
key = util.utf8(key)
189187
if value is None:
190188
continue
191189
elif hasattr(value, 'payjp_id'):
192190
yield (key, value.payjp_id)
193191
elif isinstance(value, list) or isinstance(value, tuple):
194192
for subvalue in value:
195-
yield ("%s[]" % (key,), util.utf8(subvalue))
193+
yield ("%s[]" % (key,), subvalue)
196194
elif isinstance(value, dict):
197195
subdict = dict(('%s[%s]' % (key, subkey), subvalue) for
198196
subkey, subvalue in value.items())
@@ -201,7 +199,7 @@ def _api_encode(data):
201199
elif isinstance(value, datetime.datetime):
202200
yield (key, _encode_datetime(value))
203201
else:
204-
yield (key, util.utf8(value))
202+
yield (key, value)
205203

206204
def _build_api_url(url, query):
207205
scheme, netloc, path, base_query, fragment = urlsplit(url)

payjp/resource.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import sys
66
from urllib.parse import quote_plus
77

8-
from payjp import api_requestor, error, util
8+
from payjp import api_requestor, error
99

1010
logger = logging.getLogger('payjp')
1111

@@ -239,7 +239,6 @@ def create(self, **params):
239239

240240
def retrieve(self, id, **params):
241241
base = self.get('url')
242-
id = util.utf8(id)
243242
extn = quote_plus(id)
244243
url = "%s/%s" % (base, extn)
245244

@@ -380,7 +379,6 @@ def instance_url(self):
380379
id = self.get('id')
381380
if not id:
382381
return "/v1/accounts"
383-
id = util.utf8(id)
384382
base = self.class_url()
385383
extn = quote_plus(id)
386384
return "%s/%s" % (base, extn)
@@ -389,11 +387,8 @@ def instance_url(self):
389387
class Card(UpdateableAPIResource, DeletableAPIResource):
390388

391389
def instance_url(self):
392-
self.id = util.utf8(self.id)
393390
extn = quote_plus(self.id)
394391
if (hasattr(self, 'customer')):
395-
self.customer = util.utf8(self.customer)
396-
397392
base = Customer.class_url()
398393
owner_extn = quote_plus(self.customer)
399394

payjp/test/test_requestor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class APIRequestorRequestTests(PayjpUnitTestCase):
133133
('%s[]', 'baz'),
134134
],
135135
'string': [('%s', 'boo')],
136-
'unicode': [('%s', payjp.util.utf8(u'\u1234'))],
136+
'unicode': [('%s', u'\u1234')],
137137
'datetime': [('%s', 1356994801)],
138138
'none': [],
139139
}

payjp/util.py

Lines changed: 0 additions & 9 deletions
This file was deleted.

setup.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
# coding: utf-8
2-
31
import sys
42

53
from setuptools import setup
64

75
install_requires = []
86

9-
if sys.version_info < (3, 0):
10-
raise DeprecationWarning('Python 2 is no longer supported by PAY.JP. Please use Python 3.')
7+
if sys.version_info < (3, 8):
8+
raise DeprecationWarning('Python versions below 3.8 are no longer supported by PAY.JP. Please use Python 3.8 or higher.')
119

1210
install_requires.append('requests >= 2.7.0')
1311

0 commit comments

Comments
 (0)