Fixed attach interface

There were some logic issues in how exams were attached. It now reads this correctly

Author: paustian

Controller/AdminController.php

@@ -301,23 +301,36 @@ public function attachAction(Request $request) : JsonResponse {
 
         //get rid of the old exam if there is one.    
         $old_exam = $repo->get_exam($art_id);
-        $reponse = "";
-        if ($old_exam) {
-            $old_exam->setQuickcheckrefid(-1); //no article attached
-        }
-        if (isset($attach)) {
-            if (!isset($art_id) || !isset($exam)) {
-                throw new NotFoundHttpException($this->trans('An article id or exam id are missing'));
+        $response = "";
+        $already_attached = false;
+        if (null !== $old_exam) {
+            if(($old_exam->getId() == $exam) && $attach) {
+                $response = "<p>That exam is already attached.</p>";
+                $already_attached = true;
+            } else {
+                $old_exam->setQuickcheckrefid(-1); //no article attached
+                $response = "<p>" . $old_exam->getQuickcheckname() . " was removed from the page. </p>";
             }
-            //modify the exam by grabbing it and then changing or adding the art_id
-            $new_exam = $em->find('PaustianQuickcheckModule:QuickcheckExamEntity', $exam);
-            if (null === $new_exam) {
-                throw new \Doctrine\ORM\NoResultException($this->trans('An exam was not found, when it should have been.'));
+        }
+        if(!$already_attached){
+            if (isset($attach)) {
+                if (!isset($art_id) || !isset($exam)) {
+                    throw new NotFoundHttpException($this->trans('An article id or exam id are missing'));
+                }
+                //modify the exam by grabbing it and then changing or adding the art_id
+                $new_exam = $em->find('PaustianQuickcheckModule:QuickcheckExamEntity', $exam);
+                if (null === $new_exam) {
+                    throw new \Doctrine\ORM\NoResultException($this->trans('An exam was not found, when it should have been.'));
+                }
+                $new_exam->setQuickcheckrefid((int)$art_id);
+                $response .= "<p>" . $new_exam->getQuickcheckname() ." exam was attached to the page. Reload the page to see it.</p>";
+            } else {
+                if(null !== $old_exam){
+                    $response = "<p>" . $old_exam->getQuickcheckname() ." exam was removed from the page. Reload the page to see it.</p>";
+                } else {
+                    $response = "<p> There is no exam to remove. Get it together you loser.";
+                }
             }
-            $new_exam->setQuickcheckrefid((int)$art_id);
-            $response = "<p>" . $new_exam->getQuickcheckname() ." exam was attached to the page. Reload the page to see it.</p>";
-        } else {
-            $response = "<p>" . $old_exam->getQuickcheckname() ." exam was removed from the page. Reload the page to see it.</p>";
         }
         $em->flush();
         //finally return to the page that called.

Resources/views/Hook/quickcheck.addquiz.html.twig

@@ -1,3 +1,5 @@
+{{ pageAddAsset('javascript', zasset('jquery-ui/jquery-ui.js')) }}
+{{ pageAddAsset('stylesheet', asset('jquery-ui/themes/base/jquery-ui.min.css')) }}
 {{ pageAddAsset('stylesheet', 'https://cdn.datatables.net/1.10.20/css/jquery.dataTables.css') }}
 {{ pageAddAsset('javascript', 'https://cdn.datatables.net/1.10.20/js/jquery.dataTables.js') }}
 {{ pageAddAsset('javascript', zasset('@PaustianQuickcheckModule:js/Paustian.Quickcheck.examtablesort.js')) }}
@@ -28,7 +30,7 @@
         </tbody>
     </table>
 </form>
-<button id="DialogButton"></button>
+
 <div id="dialog" title="Attach/Remove Exam">
     <p id="dialog_text"></p>
 </div>