Add table options for subscription store, also add tests folder for phpstan to analyse

Author: DanielBadura

docs/pages/configuration.md

@@ -340,6 +340,8 @@ patchlevel_event_sourcing:
     store: 
       type: 'custom' # default is 'dbal'
       service: 'my_subscription_store'
+      options:
+        table_name: 'my_subscription_store'
 ```
 !!! tip
 

docs/pages/installation.md

@@ -37,6 +37,14 @@ patchlevel_event_sourcing:
     connection:
       url: '%env(EVENTSTORE_URL)%'
       provide_dedicated_connection: true
+    store:
+      type: dbal_stream
+      merge_orm_schema: true
+    command_bus:
+      service: messenger.bus.default
+    query_bus:
+      service: messenger.bus.default
+    cryptography: ~
 
 when@dev:
   patchlevel_event_sourcing:
@@ -50,6 +58,8 @@ when@dev:
 when@test:
   patchlevel_event_sourcing:
     subscription:
+      store:
+        type: 'static_in_memory'
       catch_up: true
       throw_on_error: true
       run_after_aggregate_save: true

docs/pages/usage.md

@@ -1,7 +1,7 @@
 # Usage
 
 Here you will find some examples of how to use the bundle.
-But we provide only examples for specific symfo
+But we provide only examples for specific symfony features.
 
 !!! info
 

phpstan-baseline.neon

@@ -5,3 +5,51 @@ parameters:
 			identifier: argument.type
 			count: 1
 			path: src/DependencyInjection/QueryHandlerCompilerPass.php
+
+		-
+			message: '#^Property Patchlevel\\EventSourcingBundle\\Tests\\Fixtures\\Profile\:\:\$id is never read, only written\.$#'
+			identifier: property.onlyWritten
+			count: 1
+			path: tests/Fixtures/Profile.php
+
+		-
+			message: '#^Property Patchlevel\\EventSourcingBundle\\Tests\\Fixtures\\SnapshotableProfile\:\:\$id is unused\.$#'
+			identifier: property.unused
+			count: 1
+			path: tests/Fixtures/SnapshotableProfile.php
+
+		-
+			message: '#^Call to an undefined method Symfony\\Component\\DependencyInjection\\ContainerBuilder\:\:getAutoconfiguredAttributes\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: tests/Unit/PatchlevelEventSourcingBundleTest.php
+
+		-
+			message: '#^Cannot access offset ''Patchlevel\\\\EventSourcing\\\\Attribute\\\\Aggregate''\|''Patchlevel\\\\EventSourcing\\\\Attribute\\\\Event'' on mixed\.$#'
+			identifier: offsetAccess.nonOffsetAccessible
+			count: 1
+			path: tests/Unit/PatchlevelEventSourcingBundleTest.php
+
+		-
+			message: '#^Cannot access offset ''bus'' on mixed\.$#'
+			identifier: offsetAccess.nonOffsetAccessible
+			count: 3
+			path: tests/Unit/PatchlevelEventSourcingBundleTest.php
+
+		-
+			message: '#^Cannot access offset ''handles'' on mixed\.$#'
+			identifier: offsetAccess.nonOffsetAccessible
+			count: 3
+			path: tests/Unit/PatchlevelEventSourcingBundleTest.php
+
+		-
+			message: '#^Cannot access offset ''method'' on mixed\.$#'
+			identifier: offsetAccess.nonOffsetAccessible
+			count: 2
+			path: tests/Unit/PatchlevelEventSourcingBundleTest.php
+
+		-
+			message: '#^Trying to invoke mixed but it''s not a callable\.$#'
+			identifier: callable.nonCallable
+			count: 1
+			path: tests/Unit/PatchlevelEventSourcingBundleTest.php

phpstan.neon.dist

@@ -6,3 +6,4 @@ parameters:
 	level: max
 	paths:
 		- src
+		- tests

src/DependencyInjection/Configuration.php

@@ -22,7 +22,11 @@
  *      },
  *      query_bus: array{enabled: bool, service: string},
  *      subscription: array{
- *          store: array{type: string, service: string|null},
+ *          store: array{
+ *              type: string,
+ *              service: string|null,
+ *              options: array{table_name: string}
+ *          },
  *          retry_strategy?: array{base_delay: int, delay_factor: int, max_attempts: int},
  *          retry_strategies: array<string, array{type: string, service: string, options: array<string, mixed>}>,
  *          default_retry_strategy: string,
@@ -197,6 +201,12 @@ public function getConfigTreeBuilder(): TreeBuilder
                                 ->defaultValue('dbal')
                             ->end()
                             ->scalarNode('service')->defaultNull()->end()
+                            ->arrayNode('options')
+                                ->addDefaultsIfNotSet()
+                                ->children()
+                                    ->scalarNode('table_name')->defaultValue('subscriptions')->end()
+                                ->end()
+                            ->end()
                         ->end()
                     ->end()
 

src/DependencyInjection/PatchlevelEventSourcingExtension.php

@@ -488,6 +488,8 @@ static function (ChildDefinition $definition): void {
             $container->register(DoctrineSubscriptionStore::class)
                 ->setArguments([
                     new Reference('event_sourcing.dbal_connection'),
+                    new Reference('event_sourcing.clock'),
+                    $config['subscription']['store']['options']['table_name'],
                 ])
                 ->addTag('event_sourcing.doctrine_schema_configurator');
 

tests/Fixtures/Profile.php

@@ -16,6 +16,7 @@ class Profile extends BasicAggregateRoot
     #[Id]
     private CustomId $id;
 
+    /**  @param Repository<self> $profileRepository */
     #[Handle]
     public static function create(
         CreateProfile $command,

tests/Unit/DataCollector/EventSourcingCollectorTest.php

@@ -68,7 +68,6 @@ public function testCollectData(): void
         self::assertEquals(ProfileCreated::class, $message['event_class']);
         self::assertEquals('profile.created', $message['event_name']);
         self::assertInstanceOf(Data::class, $message['event']);
-        self::assertIsArray($message['headers']);
         self::assertCount(1, $message['headers']);
         self::assertInstanceOf(Data::class, $message['headers'][0]);
     }

tests/Unit/PatchlevelEventSourcingBundleTest.php

@@ -83,6 +83,7 @@
 use Patchlevel\EventSourcing\Subscription\Store\SubscriptionStore;
 use Patchlevel\EventSourcing\Subscription\Subscriber\MetadataSubscriberAccessorRepository;
 use Patchlevel\EventSourcingBundle\Command\StoreMigrateCommand;
+use Patchlevel\EventSourcingBundle\DependencyInjection\Configuration;
 use Patchlevel\EventSourcingBundle\DependencyInjection\PatchlevelEventSourcingExtension;
 use Patchlevel\EventSourcingBundle\EventBus\SymfonyEventBus;
 use Patchlevel\EventSourcingBundle\PatchlevelEventSourcingBundle;
@@ -1551,6 +1552,9 @@ public function testNamedRepository(): void
         self::assertSame($profileRepository, $namedArgumentProfileRepository);
     }
 
+    /**
+     * @param array{patchlevel_event_sourcing: array<string, mixed>} $config
+     */
     private function compileContainer(ContainerBuilder $container, array $config): void
     {
         $bundle = new PatchlevelEventSourcingBundle();