Use product bundle identifier in xcconfig files instead of hard coding into Info.plists.

nlutsenko · nlutsenko · commit 652d1a78a371 · 2015-12-09T20:38:34.000-08:00
diff --git a/Configurations/ParseFacebookTestApplicationV4.xcconfig b/Configurations/ParseFacebookTestApplicationV4.xcconfig
@@ -11,6 +11,7 @@
 #include "Shared/Product/Application.xcconfig"
 
 PRODUCT_NAME = ParseFacebookTestApplicationV4
+PRODUCT_BUNDLE_IDENTIFIER = com.parse.facebookutils-ios.unit.app
 
 CLANG_ENABLE_MODULES = YES
 
diff --git a/Configurations/ParseFacebookUtilsV4-UnitTests.xcconfig b/Configurations/ParseFacebookUtilsV4-UnitTests.xcconfig
@@ -12,6 +12,7 @@
 #include "Pods/Target Support Files/Pods-ParseFacebookUtilsV4-UnitTests/Pods-ParseFacebookUtilsV4-UnitTests.debug.xcconfig"
 
 PRODUCT_NAME = ParseFacebookUtilsV4-UnitTests
+PRODUCT_BUNDLE_IDENTIFIER = com.parse.facebookutils-ios.unit
 
 CLANG_ENABLE_MODULES = YES
 
diff --git a/Configurations/ParseFacebookUtilsV4-iOS.xcconfig b/Configurations/ParseFacebookUtilsV4-iOS.xcconfig
@@ -11,6 +11,7 @@
 #include "Shared/Product/Framework.xcconfig"
 
 PRODUCT_NAME = ParseFacebookUtilsV4
+PRODUCT_BUNDLE_IDENTIFIER = com.parse.facebookutils-ios
 
 MACH_O_TYPE = staticlib
 DEFINES_MODULE = YES
diff --git a/Configurations/ParseFacebookUtilsV4-tvOS.xcconfig b/Configurations/ParseFacebookUtilsV4-tvOS.xcconfig
@@ -11,6 +11,7 @@
 #include "Shared/Product/Framework.xcconfig"
 
 PRODUCT_NAME = ParseFacebookUtilsV4
+PRODUCT_BUNDLE_IDENTIFIER = com.parse.facebookutils-tvos
 
 MACH_O_TYPE = staticlib
 DEFINES_MODULE = YES
diff --git a/ParseFacebookUtils.xcodeproj/project.pbxproj b/ParseFacebookUtils.xcodeproj/project.pbxproj
@@ -553,7 +553,7 @@
 			isa = PBXProject;
 			attributes = {
 				CLASSPREFIX = PF;
-				LastUpgradeCheck = 0710;
+				LastUpgradeCheck = 0720;
 				ORGANIZATIONNAME = "Parse, LLC";
 				TargetAttributes = {
 					81CB98C51AB7905D00136FA5 = {
diff --git a/ParseFacebookUtils.xcodeproj/xcshareddata/xcschemes/ParseFacebookUtilsV4-iOS.xcscheme b/ParseFacebookUtils.xcodeproj/xcshareddata/xcschemes/ParseFacebookUtilsV4-iOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0710"
+   LastUpgradeVersion = "0720"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
diff --git a/Resources/Info-iOS.plist b/Resources/Info-iOS.plist
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>ParseFacebookUtilsV4</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.parse.ParseFacebookUtils</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>
diff --git a/Resources/Info-tvOS.plist b/Resources/Info-tvOS.plist
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>ParseFacebookUtilsV4</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.parse.parsefacebookutils-tvos</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>
diff --git a/Tests/Resources/Info.plist b/Tests/Resources/Info.plist
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>$(EXECUTABLE_NAME)</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.parse.$(PRODUCT_NAME:rfc1034identifier)</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>
diff --git a/Tests/TestApplication/Resources/Info.plist b/Tests/TestApplication/Resources/Info.plist
@@ -11,7 +11,7 @@
 	<key>CFBundleIcons~ipad</key>
 	<dict/>
 	<key>CFBundleIdentifier</key>
-	<string>com.parse.$(PRODUCT_NAME:rfc1034identifier)</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>
