Skip to content

Commit f63ad0a

Browse files
fix(scripts): remove unreachable check and redundant type annotation
Pyright (1.1.399) flagged `final is current` after isinstance(current, Alias) as unreachable since final_target returns Object. Just return final_target directly. Mypy flagged the second `next_obj` declaration as a redefinition; drop the type annotation on the rebinding.
1 parent 892f474 commit f63ad0a

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

scripts/detect-breaking-changes.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,9 @@ def _resolve_redirect(obj: griffe.Object | griffe.Alias) -> griffe.Object | grif
2626
visited.add(id(current))
2727
if isinstance(current, griffe.Alias):
2828
try:
29-
final = current.final_target
29+
return current.final_target
3030
except Exception:
3131
return None
32-
if final is current:
33-
return None
34-
return final
3532
if isinstance(current, griffe.Attribute):
3633
value = current.value
3734
parent = current.parent
@@ -46,7 +43,7 @@ def _resolve_redirect(obj: griffe.Object | griffe.Alias) -> griffe.Object | grif
4643
if isinstance(value, griffe.ExprAttribute):
4744
# Qualified path like `task_group_status.TaskGroupStatus`.
4845
# Walk segment by segment, resolving any module aliases as we go.
49-
next_obj: griffe.Object | griffe.Alias | None = parent
46+
next_obj = parent
5047
for segment in value.values:
5148
if not isinstance(segment, griffe.ExprName):
5249
continue

0 commit comments

Comments
 (0)