Prepare Nova 1.0.7 Google TV compatibility release#56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.0.7/22for a Google TV compatibility release.armeabi-v7ato the default release ABI split set so Chromecast with Google TV, Google TV Streamer, and other 32-bit ARM Android TV devices get a public APK.Nova-Android-armeabi-v7a.apkplus its checksum alongside the existing ARM64 and x86_64 assets.0x28de:0x1303) as controller input so Nova advertises a host gamepad and routes compatible D-pad/button events through the controller path.Verification
./gradlew -PnovaAbis=x86_64 :app:testNonRoot_gameDebugUnitTest --tests com.papi.nova.ui.NovaComposeBuildConfigurationTest --console=plainfailed before implementation becausearmeabi-v7awas missing from Gradle/workflow expectations.0x28de:0x1303keyboard/mouse input was not accepted as controller input.dumpsys inputevidence showingSteam Ctrl (BT) FXA9960600962as vendor0x28de, product0x1303, sourcesKEYBOARD | MOUSE | STYLUS, keyboard type2, with noGAMEPADorJOYSTICKsource.git diff --checkbash scripts/check-public-surface.shbash scripts/check-public-docs.sh./gradlew -PnovaAbis=x86_64 :app:testNonRoot_gameDebugUnitTest --tests com.papi.nova.ui.NovaComposeBuildConfigurationTest --console=plain./gradlew -PnovaAbis=x86_64 :app:testNonRoot_gameDebugUnitTest --tests com.papi.nova.binding.input.KotlinControllerHandlerMigrationTest --console=plain./gradlew -PnovaAbis=x86_64 testNonRoot_gameDebugUnitTest --console=plain./gradlew -PnovaAbis=armeabi-v7a assembleNonRoot_gameDebug lintNonRoot_gameDebug --console=plain./gradlew assembleNonRoot_gameRelease --console=plainaapt dump badging app/build/outputs/apk/nonRoot_game/release/*armeabi-v7a*release*.apkconfirmedversionCode='22'andversionName='1.0.7'.Google TV Streamerat10.0.0.149:5555: device reportsro.product.cpu.abilist=armeabi-v7a,armeabi; installedapp-nonRoot_game-armeabi-v7a-debug.apk; package reportsprimaryCpuAbi=armeabi-v7a,versionCode=22,versionName=1.0.7; launchedcom.papi.nova.debug; no fatal/ANR/native-crash logcat matches.Notes