FIX: Stata writer no longer ignores encoding when writing strings

The encoding was not used when writing strings. Fixes #7286

Author: bashtage

doc/source/v0.14.1.txt

@@ -221,7 +221,7 @@ Bug Fixes
   (:issue:`7357`)
 - Bug in ``StataReader.data`` where reading a 0-observation dta failed (:issue:`7369`)
 - Bug in when reading Stata 13 (117) files containing fixed width strings (:issue:`7360`)
-
+- Bug in when writing Stata files where the encoding was ignored (:issue:`7286`)
 
 
 

pandas/io/stata.py

@@ -1328,7 +1328,10 @@ def _write_data_nodates(self):
                         var = _pad_bytes('', typ)
                     if len(var) < typ:
                         var = _pad_bytes(var, typ)
-                    self._write(var)
+                    if compat.PY3:
+                        self._write(var)
+                    else:
+                        self._write(var.encode(self._encoding))
                 else:
                     try:
                         self._file.write(struct.pack(byteorder + TYPE_MAP[typ],
@@ -1358,7 +1361,10 @@ def _write_data_dates(self):
                 if typ <= 244:  # we've got a string
                     if len(var) < typ:
                         var = _pad_bytes(var, typ)
-                    self._write(var)
+                    if compat.PY3:
+                        self._write(var)
+                    else:
+                        self._write(var.encode(self._encoding))
                 else:
                     self._file.write(struct.pack(byteorder+TYPE_MAP[typ], var))
 

pandas/io/tests/test_stata.py

@@ -283,6 +283,11 @@ def test_encoding(self):
             self.assertEqual(result, expected)
             self.assertIsInstance(result, unicode)
 
+        with tm.ensure_clean() as path:
+            encoded.to_stata(path,encoding='latin-1', write_index=False)
+            reread_encoded = read_stata(path, encoding='latin-1')
+            tm.assert_frame_equal(encoded, reread_encoded)
+
     def test_read_write_dta11(self):
         original = DataFrame([(1, 2, 3, 4)],
                              columns=['good', compat.u('b\u00E4d'), '8number', 'astringwithmorethan32characters______'])