Skip to content

CLN: pandas.core.algorithms.value_counts is internal #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loicdiridollou merged 1 commit into from
Dec 4, 2025
Merged

CLN: pandas.core.algorithms.value_counts is internal #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pandas-stubs/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ from pandas.core.api import (
to_numeric as to_numeric,
to_timedelta as to_timedelta,
unique as unique,
value_counts as value_counts,
)
from pandas.core.arrays.sparse import SparseDtype as SparseDtype
from pandas.core.computation.api import eval as eval
Expand Down
2 changes: 1 addition & 1 deletion pandas-stubs/_libs/tslibs/timestamps.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class Timestamp(datetime, SupportsIndex):
def fold(self) -> int: ...
if sys.version_info >= (3, 12):
@classmethod
def fromtimestamp( # pyright: ignore[reportIncompatibleMethodOverride]
def fromtimestamp( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
cls, t: float, tz: _tzinfo | str | None = ...
) -> Self: ...
else:
Expand Down
9 changes: 0 additions & 9 deletions pandas-stubs/core/algorithms.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ from pandas.core.series import Series

from pandas._typing import (
T_EXTENSION_ARRAY,
AnyArrayLike,
GenericT,
IntervalT,
TakeIndexer,
Expand Down Expand Up @@ -88,14 +87,6 @@ def factorize(
use_na_sentinel: bool = ...,
size_hint: int | None = ...,
) -> tuple[np_1darray_int64, Categorical]: ...
def value_counts(
values: AnyArrayLike | list | tuple,
sort: bool = True,
ascending: bool = False,
normalize: bool = False,
bins: int | None = None,
dropna: bool = True,
) -> Series: ...
def take(
arr: np_ndarray[Any] | ExtensionArray | Index | Series,
indices: TakeIndexer,
Expand Down
1 change: 0 additions & 1 deletion pandas-stubs/core/api.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from pandas.core.algorithms import (
factorize as factorize,
unique as unique,
value_counts as value_counts,
)
from pandas.core.arrays import Categorical as Categorical
from pandas.core.arrays.arrow.dtype import ArrowDtype as ArrowDtype
Expand Down
4 changes: 3 additions & 1 deletion tests/extension/decimal/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,9 @@ def convert_values(param: Any) -> ExtensionArray | list[Any]:
return cast(np_1darray_bool, np.asarray(res, dtype=bool))

def value_counts(self, dropna: bool = True) -> Series:
from pandas.core.algorithms import value_counts
from pandas.core.algorithms import ( # type: ignore[attr-defined] # isort: skip
value_counts, # pyright: ignore[reportAttributeAccessIssue]
)

return value_counts(self.to_numpy(), dropna=dropna)

Expand Down