Do not allow falsey values to mean the same as null.

zanbaldwin · zanbaldwin · commit 456ea0de4ce9 · 2023-05-19T14:03:25.000+02:00
diff --git a/src/HttpClient/HttpPluginClientBuilder.php b/src/HttpClient/HttpPluginClientBuilder.php
@@ -34,7 +34,7 @@ class HttpPluginClientBuilder
      */
     public function __construct(?ClientInterface $httpClient = null, $requestFactory = null)
     {
-        $requestFactory = $requestFactory ?: Psr17FactoryDiscovery::findRequestFactory();
+        $requestFactory = $requestFactory ?? Psr17FactoryDiscovery::findRequestFactory();
         if ($requestFactory instanceof RequestFactory) {
             // Use same format as symfony/deprecation-contracts.
             @trigger_error(sprintf(
@@ -55,7 +55,7 @@ public function __construct(?ClientInterface $httpClient = null, $requestFactory
             ));
         }
 
-        $this->httpClient = $httpClient ?: Psr18ClientDiscovery::find();
+        $this->httpClient = $httpClient ?? Psr18ClientDiscovery::find();
         $this->requestFactory = $requestFactory;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class HttpPluginClientBuilder`
`34`	`34`	`*/`
`35`	`35`	`public function __construct(?ClientInterface $httpClient = null, $requestFactory = null)`
`36`	`36`	`{`
`37`		`- $requestFactory = $requestFactory ?: Psr17FactoryDiscovery::findRequestFactory();`
	`37`	`+ $requestFactory = $requestFactory ?? Psr17FactoryDiscovery::findRequestFactory();`
`38`	`38`	`if ($requestFactory instanceof RequestFactory) {`
`39`	`39`	`// Use same format as symfony/deprecation-contracts.`
`40`	`40`	`@trigger_error(sprintf(`
`@@ -55,7 +55,7 @@ public function __construct(?ClientInterface $httpClient = null, $requestFactory`
`55`	`55`	`));`
`56`	`56`	`}`
`57`	`57`
`58`		`- $this->httpClient = $httpClient ?: Psr18ClientDiscovery::find();`
	`58`	`+ $this->httpClient = $httpClient ?? Psr18ClientDiscovery::find();`
`59`	`59`	`$this->requestFactory = $requestFactory;`
`60`	`60`	`}`
`61`	`61`