Rd 217 #33
Open
Rd 217 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-stack
requested changes
Dec 8, 2025
outscraper/transport.py
Outdated
| See: https://app.outscraper.com/api-docs#tag/Requests/paths/~1requests~1{requestId}/get | ||
| ''' | ||
| response = requests.get(f'{api_url}/requests/{request_id}') |
Contributor
There was a problem hiding this comment.
why not using api_request here?
Collaborator
Author
There was a problem hiding this comment.
added api_request method
outscraper/transport.py
Outdated
| except requests.RequestException: | ||
| continue | ||
|
|
||
| if 500 <= response.status_code < 600: |
Contributor
There was a problem hiding this comment.
Are you sure we need it to continue for example when timeout? (questions to discuss)
Collaborator
Author
There was a problem hiding this comment.
added ConnectionError, SSLError only
outscraper/transport.py
Outdated
|
|
||
| def api_request(self, method: str, path: str, *, wait_async: bool, async_request: bool, use_handle_response: bool, **kwargs) -> Union[ | ||
| requests.Response, list, dict]: | ||
| for attempt in range(self._max_retries): |
Contributor
There was a problem hiding this comment.
why attempts? what if it will create two API tasks if the first request timed out?
Collaborator
Author
There was a problem hiding this comment.
removed additional attempts
| setup( | ||
| name='outscraper', | ||
| version='5.10.0', | ||
| version='6.0.0', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.