Merge pull request #33 from oslabs-beta/FL/RL-42-43-44/Memory-Leak_Cleanup

Fl/rl 42 43 44/memory leak cleanup

Author: Ponch49

src/extension.ts

@@ -12,15 +12,14 @@ let panel: vscode.WebviewPanel | undefined = undefined
 function activate(context: vscode.ExtensionContext) {
 
 	// This is the column where Webview will be revealed to
-	const columnToShowIn : vscode.ViewColumn | undefined = vscode.window.activeTextEditor
+	let columnToShowIn : vscode.ViewColumn | undefined = vscode.window.activeTextEditor
         ? vscode.window.activeTextEditor.viewColumn
         : undefined;
 
 
 	// Command that allows for User to select the root file of their React application.
 	const pickFile: vscode.Disposable = vscode.commands.registerCommand('myExtension.pickFile', async () => {
 
-
 		// Check if there is an existing webview panel, if so display it.
 		if(panel) {
 			panel.reveal(columnToShowIn)
@@ -52,6 +51,19 @@ function activate(context: vscode.ExtensionContext) {
 			panel.dispose()
 			panel = createPanel(context, data, columnToShowIn);
 		}
+
+		// Listens for when webview is closed and disposes of webview resources
+		panel.onDidDispose(
+			() => {
+				console.log("Before: ", panel)
+				panel.dispose()
+				panel = undefined;
+				columnToShowIn = undefined;
+				console.log("After: ", panel)
+			},
+			null,
+			context.subscriptions
+			);
 	});
 
 

src/panel.ts

@@ -35,16 +35,6 @@ export function createPanel(context: vscode.ExtensionContext, data: Tree, column
     // render html of webview here
     panel.webview.html = createWebviewHTML(bundleURI, data);
 
-
-    // Listens for when webview is closed and disposes of webview resources
-    panel.onDidDispose(
-        () => {
-          panel = undefined;
-        },
-        null,
-        context.subscriptions
-      );
-
 
     // Sends data to Flow.tsx to be displayed after parsed data is received
     panel.webview.onDidReceiveMessage(