Custom Titlebar in Linux/GTK implementation finished, please test!

[mirek-fidler]

After weeks of effort, I have finally got this working:

(The last thing was to prevent dragging titlebar when the mouse is over U++ widget - that took me 50+ hours to figure out by trial / error, ultimately ending with this ugly piece of code:

bool Ctrl::prevent_custombar_drag;

void Ctrl::SetCustomBarDragPrevention()
{ // ugly as hell, but seems to be the only simple way how to prevent window drag in custom titlebar
	static gint p1, p2;
	GtkSettings *gs = gtk_settings_get_default();
	ONCELOCK {
		g_object_get(gs, "gtk-double-click-distance", &p1, "gtk-dnd-drag-threshold", &p2, NULL);
	};
	gint s1 = p1;
	gint s2 = p2;
	if(prevent_custombar_drag)
		s1 = s2 = 1000000; // no drags for you, GtkWindow...
	g_object_set (gs, "gtk-double-click-distance", s1, "gtk-dnd-drag-threshold", s2, NULL);
}

void Ctrl::SyncPreventCustomBarDragPrevention()
{
	TopWindow *tw = dynamic_cast<TopWindow *>(this);
	prevent_custombar_drag = tw && tw->custom_bar_frame && tw->GetScreenRect().Contains(GetMousePos());
	SetCustomBarDragPrevention();
}

Anyway, the whole thing is now finally ready for testing, before I merge it, in "custome_titlebar_branch" (master is merged there, so it is really the latest U++ version now...)

I am not yet sure how this will behave in Wayland (probably will not) or XWayland (probably will, plan to test later today).

I have also feeling theide now might be a bit unstable, so perhaps try to run it in debug mode from debugger (that is what I do now...) and send backtrace if possible :)

Other than that, I have run out of "gtk custombar todo" list.

[klugier]

Hello Mirek,

Thanks for outstanding contribution!

Backing to the topic. The Wayland version works fine. As I wrote on Discord we are using GTK internals, so there is no reason it shouldn't work. I tested it and it works as expected on Wayland. I tested on UWord and Custom title bar example.

The issues, I noticed:

• Some dialog doesn't work for example Print dialog in UWord or Units in the same app. It is also afects all prompts, so for example in UWord when you enter several characters and then want to close app. It is not possible, because prompt window is broken. The only workaround is to kill the app manually. This is critical issue that needs to be solve before merging your changes to the master branch.
• There is an compilation error in CustomTitleBar reference. Please fix it. This is of course less invasive, but worth to fix before merging.

Some improvements for the future

• I don't like the default sizing for default GTK CSD titlebars. Would be good to have something lighter, especially for prompts like dialog. If title bar is the same size as window, it means that something doesn't work. This is an issue from the past and it worked like that when we introduced Wayland support for the first time. Would be nice to do something with that in the future...

[mirek-fidler]

* I don't like the default sizing for default GTK CSD titlebars. Would be good to have something lighter, especially for prompts like dialog. If title bar is the same size as window, it means that something doesn't work. This is an issue from the past and it worked like that when we introduced Wayland support for the first time. Would be nice to do something with that in the future...

There are 2 ways (or perhaps 2.5) how to do that, none of them ideal:

• We can use custom titlebars everywhere. Unfortunate result is the we lose theme styling.
• I think it should be possible to change the .css style. This however can cause incompatibilities when reduced height of titlebar would clash with other style aspects - e.g. icons can be too big or title text can be too big.
• Maybe we could improve above by assessing the allowed height (read how big icons are and what is the size of text). But it has its quirks as well :(

[mirek-fidler]

Some dialog doesn't work for example Print dialog in UWord or Units in the same app. It is also afects all prompts, so for example in UWord when you enter several characters and then want to close app. It is not possible, because prompt window is broken. The only workaround is to kill the app manually. This is critical issue that needs to be solve before merging your changes to the master branch.

Unfortunately I do not see that in kubuntu (wayland nor xwayland) - all seems fine.

Please help me to narrow this down...

CtrlCore/GtkTop.cpp:42
CtrlCore/GtkTop.cpp:106
CtrlCore/GtkWnd.cpp:164
CtrlCore/GtkWnd.cpp:201

are good places to put some DDUMPs...

If the problem manifests for simple GUI_APP_MAIN { PromptOK("!"); } it should show "bad values" somewhere....

I don't like the default sizing for default GTK CSD titlebars. Would be good to have something lighter, especially for prompts like dialog. If title bar is the same size as window, it means that something doesn't work. This is an issue from the past and it worked like that when we introduced Wayland support for the first time. Would be nice to do something with that in the future...

Interestingly, this also works fine in kubuntu (CtrlCore now has the code to disable subtitle which seems to have the right effect).

[mirek-fidler]

After refactoring much more code than hoped, I think it should now behave better....