Request to dismiss a secret-scanning alert should allow "cancel request" to be consistent with the "reopen alert" option for direct dismissals

[jalex19100]

🏷️ Discussion Type

Product Feedback

Body

A request to dismiss a secret-scanning alert shouldn't be final, for the same reason that a direct dismissal was not final. I should be able to cancel to change the rationale or undo an incorrect request for dismissal. It should not solely rely on the people approving the request, and it shouldn't sit for days in Requesting state when we know it needs to be resubmitted or left open.

Previous version of my feedback

(I didn't know direct dismissals were suddenly disabled at our org level at the time and cloud team said no changes were made to adv. security settings.)

I am working on internal tooling at our company to resolve secret scanning alerts automatically. For example, if we know it's in a third party library under /vendor/ in a go app, or we can tell it's inactive and no longer in any existing branches, we close the alert. I have existing secrets with known scenarios for testing our automation. We relied on the ability to "Reopen" the alert to re-run a known secrets alert on a new version of the code. However, alerts that I dismissed last week no longer show the "Reopen" option and I don't want to have to constantly add test secrets to repos if I don't have to. How do I keep the "reopen" option available on secret-scanning alerts where I am actively testing? Or if I cybersecurity group saw that it was closed and agreed, did they do something to make it permanently closed? Thanks!

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[jalex19100]

Okay, I see that Prevent direct alert dismissals was either newly added or enabled at our Org level in the past couple of days. So I can't re-open approved requests, I can live with that. This is a good setting to enable for security.

Under secret-scanning settings in adv. security:

Prevent direct alert dismissals.   ---  Enabled
Actors must submit requests to dismiss an alert.

However, still have the same issue, but now related to the Request for dismissal. Why can't I undo a request to dismiss an alert? It is just stuck in "Requested" state. GH secret scans let me reopen direct dismissals before. I should be able to cancel a request for dismissal to use new rationale or because it was requested by mistake.

Repasted from https://github.com/orgs/community/discussions/190415:

Could we please get consistency in the UI and API when the feature is enabled/disabled?

Assumption: User has permissions to view and dissmiss or request dismissal of a secret-scanning alert, but is not org admin.

When "delegate alert dismissal for secret scanning" is disabled:

• API allows a user to dismiss the alert
• API allows a user to cancel the dismissal
• UI allows a user to dismiss the alert
• UI allows a user to cancel the dismissal.

When "delegate alert dismissal for secret scanning" is enabled:

• API does NOT allow a user to request dismissal of the alert
• API does NOT allow a user to cancel the request for dismissal
• UI allows user to request to dismiss an alert
• UI does NOT allow a user to cancel a request to dismiss an alert

This is why I said the feature does not look like it was prod ready. Thanks.

I am looking for functional symmetry for when "delegate alert dismissal for secret scanning" is enabled or not.

[jalex19100]

Closing as a dup of https://github.com/orgs/community/discussions/190415 (which is correctly labeled as an API issue).